feat: stubbing out further endpoints based on spec - #82
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR expands the serverless surface area of the Runware CLI by scaffolding additional commands from the spec and wiring up the first functional deployment and application-inspection flows (deployments/endpoints/versions/workers), backed by new Serverless API client methods and updated generated docs.
Changes:
- Adds new
runware serverlesssubcommands/groups (init,dev,use,usage,registry,apps), with stubs for not-yet-wired leaves. - Implements
serverless deploy(packs a Python entry file into a base64 zip, creates a deployment via the serverless REST API) and implements severalserverless appslist/show endpoints. - Extends the serverless API client with deployments/endpoints/versions/workers operations, updates error-code mapping, and regenerates CLI docs.
Reviewed changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/cmd/serverless/use.go | Adds serverless use stub leaf command. |
| internal/cmd/serverless/usage.go | Adds serverless usage stub leaf command. |
| internal/cmd/serverless/stub.go | Introduces shared stub helpers for leaf/group commands. |
| internal/cmd/serverless/serverless.go | Registers new serverless subcommands and updates deploy wiring. |
| internal/cmd/serverless/registry.go | Adds serverless registry group with stub subcommands. |
| internal/cmd/serverless/pack.go | Implements Python entry-file zip+base64 packing for deploy. |
| internal/cmd/serverless/pack_test.go | Adds unit tests for Python file packing. |
| internal/cmd/serverless/init.go | Adds serverless init stub leaf command. |
| internal/cmd/serverless/gpus.go | Adjusts spinner stop timing around GPU listing. |
| internal/cmd/serverless/display.go | Adds table/json/yaml display wrappers for serverless entities. |
| internal/cmd/serverless/dev.go | Adds serverless dev stub leaf command. |
| internal/cmd/serverless/deploy.go | Implements serverless deploy (create deployment via API, flags, output). |
| internal/cmd/serverless/apps.go | Adds serverless apps group; implements list/show/endpoints/versions/workers; stubs others. |
| internal/cmd/serverless/apps_secret.go | Adds serverless apps secret stub group. |
| internal/api/serverless/errors.go | Updates HTTP-status → raw error-code mapping for better categorization. |
| internal/api/serverless/client.go | Adds deployments/endpoints/versions/workers client methods and type aliases. |
| internal/api/serverless/client_test.go | Adds tests covering new serverless client endpoints. |
| docs/runware_serverless.md | Updates top-level serverless docs to include new subcommands. |
| docs/runware_serverless_use.md | Adds generated docs for serverless use. |
| docs/runware_serverless_usage.md | Adds generated docs for serverless usage. |
| docs/runware_serverless_registry.md | Adds generated docs for serverless registry. |
| docs/runware_serverless_registry_remove.md | Adds generated docs for serverless registry remove. |
| docs/runware_serverless_registry_list.md | Adds generated docs for serverless registry list. |
| docs/runware_serverless_registry_add.md | Adds generated docs for serverless registry add. |
| docs/runware_serverless_init.md | Adds generated docs for serverless init. |
| docs/runware_serverless_dev.md | Adds generated docs for serverless dev. |
| docs/runware_serverless_deploy.md | Updates generated docs for the now-implemented serverless deploy. |
| docs/runware_serverless_apps.md | Adds generated docs for serverless apps. |
| docs/runware_serverless_apps_workers.md | Adds generated docs for serverless apps workers. |
| docs/runware_serverless_apps_versions.md | Adds generated docs for serverless apps versions. |
| docs/runware_serverless_apps_usage.md | Adds generated docs for serverless apps usage. |
| docs/runware_serverless_apps_stop.md | Adds generated docs for serverless apps stop. |
| docs/runware_serverless_apps_show.md | Adds generated docs for serverless apps show. |
| docs/runware_serverless_apps_secret.md | Adds generated docs for serverless apps secret. |
| docs/runware_serverless_apps_secret_set.md | Adds generated docs for serverless apps secret set. |
| docs/runware_serverless_apps_secret_remove.md | Adds generated docs for serverless apps secret remove. |
| docs/runware_serverless_apps_secret_list.md | Adds generated docs for serverless apps secret list. |
| docs/runware_serverless_apps_scale.md | Adds generated docs for serverless apps scale. |
| docs/runware_serverless_apps_resume.md | Adds generated docs for serverless apps resume. |
| docs/runware_serverless_apps_logs.md | Adds generated docs for serverless apps logs. |
| docs/runware_serverless_apps_list.md | Adds generated docs for serverless apps list. |
| docs/runware_serverless_apps_endpoints.md | Adds generated docs for serverless apps endpoints. |
| docs/runware_serverless_apps_delete.md | Adds generated docs for serverless apps delete. |
Suppressed comments (7)
internal/cmd/serverless/apps.go:258
- Use
<deploymentId>consistently for deployment identifiers. This subcommand currently uses<name>, which conflicts with otherserverless appscommands (show <deploymentId>,versions <deploymentId>, etc.).
"scale <name>",
internal/cmd/serverless/apps.go:268
- Use
<deploymentId>consistently for deployment identifiers. This subcommand currently uses<name>, which conflicts with otherserverless appscommands (show <deploymentId>,versions <deploymentId>, etc.).
"usage <name>",
internal/cmd/serverless/apps.go:278
- Use
<deploymentId>consistently for deployment identifiers. This subcommand currently uses<name>, which conflicts with otherserverless appscommands (show <deploymentId>,workers <deploymentId>, etc.).
"stop <name>",
internal/cmd/serverless/apps.go:288
- Use
<deploymentId>consistently for deployment identifiers. This subcommand currently uses<name>, which conflicts with otherserverless appscommands (show <deploymentId>,workers <deploymentId>, etc.).
"resume <name>",
internal/cmd/serverless/apps.go:298
- Use
<deploymentId>consistently for deployment identifiers. This subcommand currently uses<name>, which conflicts with otherserverless appscommands (show <deploymentId>,workers <deploymentId>, etc.).
"delete <name>",
internal/cmd/serverless/apps_secret.go:28
- The argument placeholder
<name>is ambiguous here; in the rest of theserverless appssurface area the deployment identifier is called<deploymentId>. Renaming the placeholder improves consistency in--helpoutput and generated docs.
internal/cmd/serverless/apps_secret.go:38 - The argument placeholder
<name>is ambiguous here; in the rest of theserverless appssurface area the deployment identifier is called<deploymentId>. Renaming the placeholder improves consistency in--helpoutput and generated docs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.