Repository navigation
Pin SDK 10.0.403 and install it into a job-owned root - #50
Merged
Merged
Conversation
The runic-sdk shell has provided only SDK 10.0.403 since its 2026-10-27 security update (.NET runtime 10.0.14), so with 10.0.401 pinned and rollForward disabled the documented local commands no longer start. setup-dotnet reads the same global.json, so CI and local builds agree. CI also installed the SDK into the image's shared dotnet root. On the ubuntu-26.04 image (ubuntu-latest since 20261111) that root ships .NET 11, so the dotnet host was 11.0.0 and tests ran on whatever runtimes the image preinstalled. This fork has no host check, so nothing failed (the ReactiveUI.Validation fork's does), but the toolchain was not the locked one. DOTNET_INSTALL_DIR now points every setup-dotnet step at runner.temp, which setup-dotnet puts first on PATH and in DOTNET_ROOT. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK pin
global.json(and CONTRIBUTING.md) go from 10.0.401 to 10.0.403, the only SDK the runic-sdk dev shell has provided since its 2026-10-27 security update. WithrollForward: disable, the documented local commands did not start. Every CIsetup-dotnetstep usesglobal-json-file: global.json, so CI installs the same SDK. Nothing else in the fork names the SDK version;Microsoft.SourceLink.GitHub10.0.401 is an independent package version and stays. Locally, both Primitives generations and both flavours build and test on 10.0.403 (the full matrix for the error-forwarding PR ran on it).Locked host in CI
Same exposure as Runic-Artifex/ReactiveUI.Validation#13. On
ubuntu-latest(ubuntu-26.04 since 20261111), setup-dotnet added the SDK to/usr/share/dotnet, which ships .NET 11, so thedotnethost was 11.0.0. This fork has no host-version check, so nothing failed, but tests ran under the image's host and runtimes rather than the locked toolchain. Everysetup-dotnetstep (Build: 3, release: 2) now setsDOTNET_INSTALL_DIR: ${{ runner.temp }}/dotnet, which setup-dotnet puts first onPATHand inDOTNET_ROOT. I chose this over pinning a runner image, which would move on too.actionlintis clean. Kept separate from the error-forwarding fix (#47/#48) so each change is reviewed on its own.🤖 Generated with Claude Code