Skip to content

Pin SDK 10.0.403 and install it into a job-owned root - #50

Merged
ViktorJannicke merged 1 commit into
mainfrom
build/sdk-10.0.403-isolated-root
Nov 19, 2026
Merged

ViktorJannicke merged 1 commit into
mainfrom
build/sdk-10.0.403-isolated-root

Conversation

@ViktorJannicke

Copy link
Copy Markdown

SDK pin

global.json (and CONTRIBUTING.md) go from 10.0.401 to 10.0.403, the only SDK the runic-sdk dev shell has provided since its 2026-10-27 security update. With rollForward: disable, the documented local commands did not start. Every CI setup-dotnet step uses global-json-file: global.json, so CI installs the same SDK. Nothing else in the fork names the SDK version; Microsoft.SourceLink.GitHub 10.0.401 is an independent package version and stays. Locally, both Primitives generations and both flavours build and test on 10.0.403 (the full matrix for the error-forwarding PR ran on it).

Locked host in CI

Same exposure as Runic-Artifex/ReactiveUI.Validation#13. On ubuntu-latest (ubuntu-26.04 since 20261111), setup-dotnet added the SDK to /usr/share/dotnet, which ships .NET 11, so the dotnet host was 11.0.0. This fork has no host-version check, so nothing failed, but tests ran under the image's host and runtimes rather than the locked toolchain. Every setup-dotnet step (Build: 3, release: 2) now sets DOTNET_INSTALL_DIR: ${{ runner.temp }}/dotnet, which setup-dotnet puts first on PATH and in DOTNET_ROOT. I chose this over pinning a runner image, which would move on too.

actionlint is clean. Kept separate from the error-forwarding fix (#47/#48) so each change is reviewed on its own.

🤖 Generated with Claude Code

The runic-sdk shell has provided only SDK 10.0.403 since its 2026-10-27
security update (.NET runtime 10.0.14), so with 10.0.401 pinned and
rollForward disabled the documented local commands no longer start.
setup-dotnet reads the same global.json, so CI and local builds agree.

CI also installed the SDK into the image's shared dotnet root. On the
ubuntu-26.04 image (ubuntu-latest since 20261111) that root ships .NET 11,
so the dotnet host was 11.0.0 and tests ran on whatever runtimes the
image preinstalled. This fork has no host check, so nothing failed (the
ReactiveUI.Validation fork's does), but the toolchain was not the locked
one. DOTNET_INSTALL_DIR now points every setup-dotnet step at runner.temp,
which setup-dotnet puts first on PATH and in DOTNET_ROOT.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ViktorJannicke
ViktorJannicke merged commit c0db871 into main Nov 19, 2026
7 checks passed
@ViktorJannicke
ViktorJannicke deleted the build/sdk-10.0.403-isolated-root branch November 19, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant