Skip to content

Record the 2026-11 upstream review and port the deterministic cross-feeding test - #49

Merged
ViktorJannicke merged 3 commits into
mainfrom
docs/upstream-review-2026-11
Nov 19, 2026
Merged

ViktorJannicke merged 3 commits into
mainfrom
docs/upstream-review-2026-11

Conversation

@ViktorJannicke

Copy link
Copy Markdown

Closes #46.

Review (docs/maintenance.md "Monthly upstream review")

Validation

Local (runic-sdk shell, Primitives 9.0.0, Release): CacheParentSubscriptionFixture 10/10 in DynamicData.Tests and DynamicData.Reactive.Tests, ×5 runs each. Local builds needed a temporary global.json change to SDK 10.0.403, not committed: the fork pins 10.0.401 with rollForward: disable, and the runic-sdk shell has provided only 10.0.403 since its 2026-10-27 security update.

🤖 Generated with Claude Code

ViktorJannicke and others added 2 commits November 19, 2026 11:10
Port of upstream reactivemarbles#1213 (4b2725a), adapted to
TUnit. The old test raced two Task.Run writers through a barrier and a
30 s WhenAny guard, and its writes crossed only the source caches, so it
still passed when CacheParentSubscription held its gate during delivery.

Each writer now parks inside its own subscription's delivery until the
other is there too, then feeds the other through its child observable and
its source cache, on a dedicated thread. [Timeout(10_000)] bounds a hang.
The test asserts the exact contents of both caches and observers.

Holding SharedDeliveryQueue's gate across DrainAll makes it time out on
every run. The fixture is already [NotInParallel], and the parked-delivery
SharedDeliveryQueue tests already run outside the parallel phase with
[Timeout], so upstream's second commit (b0511a1) has no counterpart here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No sync: deps/CI only. The six upstream commits since the baseline are
dependency and workflow bumps, and the virtual merge conflicts only in the
fork's own workflows and Directory.Packages.props.

Register the review's new items. reactivemarbles#1213 is ported as a test, and
reactivemarbles#1214/reactivemarbles#1219 map to DD-030/DD-031: upstream's randomized aggregate oracle
passes against the fork in both flavours. The incremental Maximum/Minimum
is deferred. reactivemarbles#1208 and reactivemarbles#1209 reproduce in both flavours and become fork
issues #47 and #48. Dependency, CI and release items are not applicable.
Move the closed October gaps (#4, #5, #6, #8) to Adopted. DD-030 now notes
that reactivemarbles#1167 merged upstream without SumImmutable.

Refs #46

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ViktorJannicke
ViktorJannicke merged commit 3339d1d into main Nov 19, 2026
7 checks passed
@ViktorJannicke
ViktorJannicke deleted the docs/upstream-review-2026-11 branch November 19, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream review 2026-11

1 participant