Repository navigation
Record the 2026-11 upstream review and port the deterministic cross-feeding test - #49
Merged
Merged
Conversation
Port of upstream reactivemarbles#1213 (4b2725a), adapted to TUnit. The old test raced two Task.Run writers through a barrier and a 30 s WhenAny guard, and its writes crossed only the source caches, so it still passed when CacheParentSubscription held its gate during delivery. Each writer now parks inside its own subscription's delivery until the other is there too, then feeds the other through its child observable and its source cache, on a dedicated thread. [Timeout(10_000)] bounds a hang. The test asserts the exact contents of both caches and observers. Holding SharedDeliveryQueue's gate across DrainAll makes it time out on every run. The fixture is already [NotInParallel], and the parked-delivery SharedDeliveryQueue tests already run outside the parallel phase with [Timeout], so upstream's second commit (b0511a1) has no counterpart here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No sync: deps/CI only. The six upstream commits since the baseline are dependency and workflow bumps, and the virtual merge conflicts only in the fork's own workflows and Directory.Packages.props. Register the review's new items. reactivemarbles#1213 is ported as a test, and reactivemarbles#1214/reactivemarbles#1219 map to DD-030/DD-031: upstream's randomized aggregate oracle passes against the fork in both flavours. The incremental Maximum/Minimum is deferred. reactivemarbles#1208 and reactivemarbles#1209 reproduce in both flavours and become fork issues #47 and #48. Dependency, CI and release items are not applicable. Move the closed October gaps (#4, #5, #6, #8) to Adopted. DD-030 now notes that reactivemarbles#1167 merged upstream without SumImmutable. Refs #46 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46.
Review (docs/maintenance.md "Monthly upstream review")
65016e5, upstreamfd20189has 6 commits (Update actions/upload-artifact action to v7 reactivemarbles/DynamicData#1090, Update dependency coverlet.collector to v10 reactivemarbles/DynamicData#1108, Update dotnet monorepo to v10 reactivemarbles/DynamicData#1117, Update actions/checkout action to v7 reactivemarbles/DynamicData#1121, Update actions/setup-dotnet action to v5.4.0 reactivemarbles/DynamicData#1172, Update dependency Nerdbank.GitVersioning to 3.10.94 reactivemarbles/DynamicData#1204), all dependency or workflow bumps.git merge-treeagainstorigin/mainconflicts in exactly the 8 reported paths: 7 workflows andsrc/Directory.Packages.props. Each is fork-owned (DD-025 / fork CPM).SumImmutable. DD-030's upstream status is updated; the 2026-12 review compares it.RandomizedAggregationFixture(2,000 random cache/list edits, plain/filtered/sorted, every aggregate against LINQ) to a scratch TUnit fixture, not committed. It passes 6/6 in both flavours. The only extra in Make Avg, StdDev, Maximum and Minimum refresh-aware reactivemarbles/DynamicData#1219 is the incremental extremum: it rebuilds only when the extreme leaves, while the fork recomputes in O(n) per Refresh, Update or Remove batch. That is deferred in the register, so no fork issue.CacheParentSubscriptiontest): the fork had the old test, so it is ported (commit 1, adapted to TUnit). HoldingSharedDeliveryQueue's gate acrossDrainAllmakes the new test time out every run; unmodified, it passed 5/5 per flavour. Upstream's second commit (moving theSharedDeliveryQueueparked-delivery tests out of the parallel phase) is already the fork's state ([NotInParallel],[Timeout]).SubscribeManyrethrows source errors) and Fix that the specialised aggregators throw source errors instead of recording them reactivemarbles/DynamicData#1209 → Sorted, paged and distinct AsAggregator rethrow source errors instead of recording them #48 (Sorted/Paged/DistinctAsAggregatorrethrow source errors). Both reproduce onmainin both flavours with upstream's tests.Validation
Local (runic-sdk shell, Primitives 9.0.0, Release):
CacheParentSubscriptionFixture10/10 inDynamicData.TestsandDynamicData.Reactive.Tests, ×5 runs each. Local builds needed a temporaryglobal.jsonchange to SDK 10.0.403, not committed: the fork pins 10.0.401 withrollForward: disable, and the runic-sdk shell has provided only 10.0.403 since its 2026-10-27 security update.🤖 Generated with Claude Code