Repository navigation
Publish to nuget.org as RunicArtifex.DynamicData with trusted publishing - #43
Merged
Merged
Conversation
…micData.Reactive The new IDs share the RunicArtifex.* prefix, which can be reserved on nuget.org for the fork. Namespaces and assembly names stay DynamicData and DynamicData.Reactive. The csproj PackageIds, acceptance consumers and source mapping, release guard, fixtures (renamed), CI package checks and docs follow the new IDs. Earlier GitHub-asset previews used Runic.DynamicData*. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Authors become "Roland Pheasant, Runic Artifex" and Owners is removed, so nuget.org takes owners from the account. Copyright and the MIT license are unchanged. Title and Description now start by naming the Runic Artifex fork of DynamicData for .NET 10 and its Rx flavor, followed by a short summary of DynamicData. The release guard checks these fields, with tests for upstream authorship, a declared owner and an upstream title. The Visual Studio [Rr]elease/ ignore rule also matched eng/release, so new fixtures there were silently left out; .gitignore now re-includes eng/release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The README and CONTRIBUTING linked GitHub release assets for downloads; they now link the nuget.org package pages and keep GitHub releases for release notes. The runic-sdk feat/dynamicdata-collections branch no longer exists and its DynamicData guide is not on runic-sdk main, so that link is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
release.yml now has four jobs. packages builds, tests, packs and runs every check read-only; github-release creates the GitHub prerelease as before; nuget runs in the nuget environment, the only job with id-token: write, logs in with NuGet/login and pushes the same artifact with dotnet nuget push; indexed waits, without secrets, up to an hour until the flat container lists both versions. The dry-run input (default true) stops after packages. Before the first push, eng/release/nuget.py checks each package with keyless lookups: the ID must match the mirrored trusted-publishing glob RunicArtifex.*, a missing version needs a new ID or one owned by runic-artifex, and an existing version is downloaded and compared entry by entry, ignoring the repository signature nuget.org adds. Identical versions are skipped and changed ones refused, so rerunning a failed nuget job is safe. The offline tests add a mock nuget.org server and a dotnet mock covering new IDs, identical and different published versions, a foreign or unknown owner, an ID outside the glob, a partial push and its retry, the indexing wait and the dry-run commands. The release guide and maintenance guide document the jobs, retries and the nuget.org account setup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in #42, which groups main Build runs by commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares the fork for publishing to nuget.org under new package IDs. Nothing is published until Package release is run by hand with dry-run unchecked, after the account setup below.
Changes
Package IDs:
Runic.DynamicData/Runic.DynamicData.ReactivebecomeRunicArtifex.DynamicData/RunicArtifex.DynamicData.Reactive. TheRunicArtifex.*prefix is easier to reserve on nuget.org thanRunic.*, and both new IDs are free.AGENTS.md.DynamicDataandDynamicData.Reactive.Fork attribution:
Ownersis removed.README: package links point to nuget.org; GitHub releases stay the place for release notes. The removed link pointed to a runic-sdk branch that no longer exists.
release.ymlnow runs four jobs:packagesgithub-releasecontents: writenugetnuget: keyless re-check,NuGet/login(trusted publishing),dotnet nuget pushid-token: writeindexeddry-runis aworkflow_dispatchinput, on by default. A dry run stops afterpackages.packages.Push checks (
eng/release/release-assets.sh nuget-check/nuget-push):RunicArtifex.*and be either new or owned byrunic-artifex..signature.p7s, which nuget.org adds to every package it accepts.eng/release/nuget-policy.jsonmirrors the nuget.org policy..gitignore: the Visual Studio rule[Rr]elease/was hiding new files undereng/release/, so that directory is now excluded from it.Account setup (manual, before the first real release)
runic-artifex: repository ownerRunic-Artifex, repositoryDynamicData, workflowrelease.yml, environmentnuget, allowed to push new packages matchingRunicArtifex.*.NUGET_USERto the nuget.org profile name that owns the policy.nuget, limited tomain, with required reviewers.RunicArtifex.*prefix forrunic-artifex.This is also in
eng/release/README.mdanddocs/maintenance.md.Verification
bash eng/release/test-release-assets.sh: passes. The mocked nuget.org covers:actionlintandshellcheck: clean.RunicArtifex.*packages, and the guard'svalidatepasses on them.verify-consumers.sh managed: pass.Outside this repo
examples/dynamicdata/README.mdmentionsRunic.DynamicDataonce. The example builds the fork from source.Runic.DynamicData*10.0.0-runic.30 from GitHub assets. It keeps working, but moving it to nuget.org means new IDs and new SHA-256 pins, because nuget.org's signed copies hash differently from the GitHub assets.🤖 Generated with Claude Code