Skip to content

Publish to nuget.org as RunicArtifex.DynamicData with trusted publishing - #43

Merged
ViktorJannicke merged 5 commits into
mainfrom
runic/nuget-release
Oct 20, 2026
Merged

ViktorJannicke merged 5 commits into
mainfrom
runic/nuget-release

Conversation

@ViktorJannicke

Copy link
Copy Markdown

This PR prepares the fork for publishing to nuget.org under new package IDs. Nothing is published until Package release is run by hand with dry-run unchecked, after the account setup below.

Changes

  • Package IDs: Runic.DynamicData / Runic.DynamicData.Reactive become RunicArtifex.DynamicData / RunicArtifex.DynamicData.Reactive. The RunicArtifex.* prefix is easier to reserve on nuget.org than Runic.*, and both new IDs are free.

    • Updated: project files, the release guard and its fixtures, acceptance consumers, consumer verification, CI, tests, docs and AGENTS.md.
    • Namespaces and assembly names are unchanged: DynamicData and DynamicData.Reactive.
    • The docs note that earlier GitHub-asset previews used the old IDs.
  • Fork attribution:

    • Authors are "Roland Pheasant, Runic Artifex", and Owners is removed.
    • Title and description now say this is the Runic Artifex fork, for .NET 10 with ReactiveUI.Primitives (or System.Reactive for the Reactive package).
    • The copyright line and MIT license are unchanged.
  • README: package links point to nuget.org; GitHub releases stay the place for release notes. The removed link pointed to a runic-sdk branch that no longer exists.

  • release.yml now runs four jobs:

    Job What it does Permissions
    packages build, test, pack, every check (including keyless nuget.org lookups), artifact plus hashes read-only
    github-release creates the GitHub prerelease, as before contents: write
    nuget runs in environment nuget: keyless re-check, NuGet/login (trusted publishing), dotnet nuget push the only job with id-token: write
    indexed waits up to an hour until nuget.org lists both versions no secrets
    • dry-run is a workflow_dispatch input, on by default. A dry run stops after packages.
    • The later jobs check their downloaded packages against the hashes from packages.
  • Push checks (eng/release/release-assets.sh nuget-check / nuget-push):

    • Each ID must match RunicArtifex.* and be either new or owned by runic-artifex.
    • If a version is already on nuget.org, it is skipped when its contents are identical and the run fails when they differ. The comparison is entry by entry and ignores .signature.p7s, which nuget.org adds to every package it accepts.
    • A failed release can be finished with "Re-run failed jobs".
    • eng/release/nuget-policy.json mirrors the nuget.org policy.
  • .gitignore: the Visual Studio rule [Rr]elease/ was hiding new files under eng/release/, so that directory is now excluded from it.

Account setup (manual, before the first real release)

  1. nuget.org: add a Trusted Publishing policy for runic-artifex: repository owner Runic-Artifex, repository DynamicData, workflow release.yml, environment nuget, allowed to push new packages matching RunicArtifex.*.
  2. Repository variable: set NUGET_USER to the nuget.org profile name that owns the policy.
  3. GitHub environment: create nuget, limited to main, with required reviewers.
  4. Optional: ask nuget.org to reserve the RunicArtifex.* prefix for runic-artifex.
  5. Run Package release once with dry-run checked.

This is also in eng/release/README.md and docs/maintenance.md.

Verification

  • bash eng/release/test-release-assets.sh: passes. The mocked nuget.org covers:
    • a new ID;
    • an identical existing version (skipped);
    • a different existing version (fails);
    • an ID owned by someone else, or with unknown owners (fails);
    • an ID outside the glob (fails);
    • a partial push and its retry;
    • the dry run;
    • the indexing wait;
    • that every lookup is keyless.
  • actionlint and shellcheck: clean.
  • Full suites, Primitives 8.4.0 and 9.0.0: 4245/4245 in the Primitives flavour and 4242/4242 in the Reactive flavour. Pack produced the two RunicArtifex.* packages, and the guard's validate passes on them.
  • Package acceptance (managed) and verify-consumers.sh managed: pass.

Outside this repo

  • runic-sdk: examples/dynamicdata/README.md mentions Runic.DynamicData once. The example builds the fork from source.
  • ReactiveUI.Validation: pinned to Runic.DynamicData* 10.0.0-runic.30 from GitHub assets. It keeps working, but moving it to nuget.org means new IDs and new SHA-256 pins, because nuget.org's signed copies hash differently from the GitHub assets.

🤖 Generated with Claude Code

ViktorJannicke and others added 5 commits October 20, 2026 16:40
…micData.Reactive

The new IDs share the RunicArtifex.* prefix, which can be reserved on
nuget.org for the fork. Namespaces and assembly names stay DynamicData and
DynamicData.Reactive. The csproj PackageIds, acceptance consumers and source
mapping, release guard, fixtures (renamed), CI package checks and docs follow
the new IDs. Earlier GitHub-asset previews used Runic.DynamicData*.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Authors become "Roland Pheasant, Runic Artifex" and Owners is removed, so
nuget.org takes owners from the account. Copyright and the MIT license are
unchanged. Title and Description now start by naming the Runic Artifex fork
of DynamicData for .NET 10 and its Rx flavor, followed by a short summary of
DynamicData. The release guard checks these fields, with tests for upstream
authorship, a declared owner and an upstream title.

The Visual Studio [Rr]elease/ ignore rule also matched eng/release, so new
fixtures there were silently left out; .gitignore now re-includes eng/release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The README and CONTRIBUTING linked GitHub release assets for downloads; they
now link the nuget.org package pages and keep GitHub releases for release
notes. The runic-sdk feat/dynamicdata-collections branch no longer exists and
its DynamicData guide is not on runic-sdk main, so that link is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
release.yml now has four jobs. packages builds, tests, packs and runs every
check read-only; github-release creates the GitHub prerelease as before; nuget
runs in the nuget environment, the only job with id-token: write, logs in with
NuGet/login and pushes the same artifact with dotnet nuget push; indexed waits,
without secrets, up to an hour until the flat container lists both versions.
The dry-run input (default true) stops after packages.

Before the first push, eng/release/nuget.py checks each package with keyless
lookups: the ID must match the mirrored trusted-publishing glob
RunicArtifex.*, a missing version needs a new ID or one owned by
runic-artifex, and an existing version is downloaded and compared entry by
entry, ignoring the repository signature nuget.org adds. Identical versions
are skipped and changed ones refused, so rerunning a failed nuget job is safe.

The offline tests add a mock nuget.org server and a dotnet mock covering new
IDs, identical and different published versions, a foreign or unknown owner,
an ID outside the glob, a partial push and its retry, the indexing wait and the
dry-run commands. The release guide and maintenance guide document the jobs,
retries and the nuget.org account setup.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in #42, which groups main Build runs by commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ViktorJannicke
ViktorJannicke merged commit 3739467 into main Oct 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant