Skip to content

Fix async peer LLM token lookup, duplicate token bug, and improve async message view#1162

Merged
bnmnetp merged 8 commits intoRunestoneInteractive:mainfrom
sethbern:main
Feb 26, 2026
Merged

Fix async peer LLM token lookup, duplicate token bug, and improve async message view#1162
bnmnetp merged 8 commits intoRunestoneInteractive:mainfrom
sethbern:main

Conversation

@sethbern
Copy link
Contributor

This PR fixes a few issues with the async peer LLM feature and cleans up the instructor view.

There was a duplicate token issue on the add token screen, the custom provider name input happened to share the token-input CSS class with the actual key field, so the submit handler was collecting it as a second token every time. The renamed class fixes this.

Fixed it so all messages from a student show up in order instead of just their last one in async peer when there is no llm. Also the LLM prompt has been updated.

@sethbern sethbern requested a review from bnmnetp as a code owner February 25, 2026 15:52
@sethbern
Copy link
Contributor Author

sethbern commented Feb 25, 2026

This also fixes issue #612

Fixes issue where the dropdown menu on the course home and course navigation showed up as white on white text.

Copy link
Member

@bnmnetp bnmnetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you forcing the course home page to be in dark mode?

I can see the problem you describe on RST built book pages where you turn on dark mode, but I believe that we have variables defined to use with the different modes. RST books are deprecated but I'm happy to merge PRs for them by others.

I would prefer this be done as a separate PR from the LLM token lookup. It makes it easier to track and easier to back out a merge if needed.

@sethbern
Copy link
Contributor Author

@bnmnetp the dark mode fix has been moved to its own #1164. To answer your question: dark mode isn't being forced, it's user-activated via a toggle in the navbar that sets data-theme="dark" on the element. The styles just weren't covering that attribute for the dropdown menus.

@sethbern sethbern requested a review from bnmnetp February 26, 2026 14:50
@bnmnetp bnmnetp merged commit 03d0e52 into RunestoneInteractive:main Feb 26, 2026
1 check passed
@bnmnetp
Copy link
Member

bnmnetp commented Mar 1, 2026

Thanks for the fix!!

I didn't expect that the custom option would be used (ever??!!) so I'm curious why you used this instead of openai?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants