Run CI on pull requests - #33
Merged
Merged
Conversation
The Test workflow only triggered on `push`, so pull requests from forks never ran any checks — the push event fires on the fork, not here. PR #31 sat with zero status checks for this reason. Switch to the push+pull_request trigger already used by every other RubyMoney repo, and add the matching read-only permissions block. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Was pinned at v3. v7.0.1 is the current release; the rest of the RubyMoney repos are still on v6. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
yukideluxe
commented
Jul 27, 2026
| pull_request: | ||
| branches: [main] | ||
|
|
||
| permissions: |
Member
Author
There was a problem hiding this comment.
@sunny claude recommended to restrict the needed permissions for this workflow in the file level instead of relying on the repo setting and I left it because it's how it's set up in the money repo ✌🏻
PS: it might be worth trying to consolidate the settings for all repos 😬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sunny I asked Claude about the CI problem because I don't know a lot about Github Actions 🙈 That said, I confirmed the changes with the official documentation and confirmed we have the same setup in other RubyMoney repos like, for example,
money😊⬇️ Claude description
The
Testworkflow triggered onon: [push]only. For a pull request from a fork the push event fires on the contributor's repo, not on this one, so fork PRs never ran any checks at all — #31 has been sitting with an empty status check list since it was opened.This switches the trigger to
push+pull_requestscoped tomain, which is the pattern already used by every other repo in the RubyMoney org (money,money-rails,monetize,eu_central_bank,money-collection,money-heuristics). It also adds thepermissions: contents: readblock those repos carry, and bumpsactions/checkoutfrom v3 to v7 to match them.