Skip to content

reject negative token values in compressed stream receivers #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tridge merged 1 commit into from
Dec 30, 2025
Merged

reject negative token values in compressed stream receivers #835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions token.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,8 +590,13 @@ static int32 recv_deflated_token(int f, char **data)
if (flag & TOKEN_REL) {
rx_token += flag & 0x3f;
flag >>= 6;
} else
} else {
rx_token = read_int(f);
if (rx_token < 0) {
rprintf(FERROR, "invalid token number in compressed stream\n");
exit_cleanup(RERR_PROTOCOL);
}
}
if (flag & 1) {
rx_run = read_byte(f);
rx_run += read_byte(f) << 8;
Expand Down Expand Up @@ -834,8 +839,13 @@ static int32 recv_zstd_token(int f, char **data)
if (flag & TOKEN_REL) {
rx_token += flag & 0x3f;
flag >>= 6;
} else
} else {
rx_token = read_int(f);
if (rx_token < 0) {
rprintf(FERROR, "invalid token number in compressed stream\n");
exit_cleanup(RERR_PROTOCOL);
}
}
if (flag & 1) {
rx_run = read_byte(f);
rx_run += read_byte(f) << 8;
Expand Down Expand Up @@ -998,8 +1008,13 @@ static int32 recv_compressed_token(int f, char **data)
if (flag & TOKEN_REL) {
rx_token += flag & 0x3f;
flag >>= 6;
} else
} else {
rx_token = read_int(f);
if (rx_token < 0) {
rprintf(FERROR, "invalid token number in compressed stream\n");
exit_cleanup(RERR_PROTOCOL);
}
}
if (flag & 1) {
rx_run = read_byte(f);
rx_run += read_byte(f) << 8;
Expand Down