Fixed bug causing yaml file loading to fail on design model 002.#6
Open
hdieckhaus wants to merge 1 commit into
Open
Fixed bug causing yaml file loading to fail on design model 002.#6hdieckhaus wants to merge 1 commit into
hdieckhaus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that causes inference to fail if
--design_model design_002is used instead of the defaultdesign_020. The reason it fails is thatdesign_002.yamldoes not exist. This PR fixes the issue by always loadingdesign_020.yaml, even for thedesign_002model. This is fine because they only differ by thebb_noisefield, which is not used in inference.