Skip to content

[Fix] Guard GitLab OAuth public callback URL selection with regression tests #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brunobergher merged 1 commit into from
Jul 15, 2026
Merged

[Fix] Guard GitLab OAuth public callback URL selection with regression tests #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/docs/providers/source-control/gitlab.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ GitLab does not have a GitHub-style App installation flow. Configure a GitLab
OAuth application for Roomote's deployment, then authorize it once so Roomote
can sync repositories, run tasks, add merge-request notes, and manage webhooks.

Use `<public-url>` below for your stable public Roomote URL.
Use `<public-url>` below for your stable public Roomote URL (`R_PUBLIC_URL`
when set, otherwise `R_APP_URL`). The GitLab OAuth application redirect URI must
match the callback Roomote builds for authorize and token exchange.

## Create a GitLab OAuth application

Expand Down
118 changes: 118 additions & 0 deletions apps/web/src/app/api/source-control/gitlab/oauth/authorize/__tests__/route.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

150 changes: 150 additions & 0 deletions apps/web/src/app/api/source-control/gitlab/oauth/callback/__tests__/route.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 13 additions & 1 deletion packages/gitlab/src/__tests__/oauth.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading