Skip to content

[Feat] Ask after PR open whether to auto-address CI and review feedback#354

Draft
roomote-roomote[bot] wants to merge 3 commits into
developfrom
feature/pr-skill-followup-opt-in-35bhrjdexdqob
Draft

[Feat] Ask after PR open whether to auto-address CI and review feedback#354
roomote-roomote[bot] wants to merge 3 commits into
developfrom
feature/pr-skill-followup-opt-in-35bhrjdexdqob

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

Internal workflow improvement (no linked issue).

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

After a successful create-pr or create-draft-pr delivery, agents now offer a single lightweight conversational follow-up: whether the user wants later CI failures or review feedback on the opened PR auto-addressed.

The offer is casually nestled in the delivery closeout—not a structured form, not request_user_input, and without coaching wording like "reply yes or no". Opt-in only. No-op and failed deliveries skip it. When the user opts in, follow-up uses existing paths (fix-pr, address-pr-feedback, CI investigation) on the same PR.

How it was tested

  • Added postPrFollowupOptIn.test.ts covering both delivery skills, including bans on structured input and answer-format coaching
  • Ran the targeted Vitest coverage for the new contract
  • Pre-push hooks: lint:fast, check-types:fast, and knip passed

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

@roomote-roomote

roomote-roomote Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

1 issue outstanding. See task

  • packages/cloud-agents/src/server/workflows/skills/standard/create-pr/SKILL.md:198 and packages/cloud-agents/src/server/workflows/skills/standard/create-draft-pr/SKILL.md:198 - An opt-in cannot trigger the promised later CI/review remediation: no instruction persists the choice or registers a resume path, while the existing PR-activity worker only posts an informational message and never starts an agent turn. A user who selects Yes will still need to manually request the fix when feedback arrives.

Reviewed 55f0251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant