[Fix] GitLab OAuth, Gitea bot loops, Docker cleanup, and PR funnel scoping#352
Merged
Conversation
Use OAuth-aware GitLab listing headers, ignore Gitea deployment-token bots, clean nested Docker daemons on failed standby resume, prefer public OAuth callback URLs, stop source-control form resets on status refetch, and scope instance-report PR funnel keys by host.
Contributor
Author
|
No code issues found. See task
Reviewed ea365ab |
Contributor
Author
|
Fixed the standby-resume daemon cleanup stack from the Roomote review summary. Change: on a failed standby resume for nested-Docker project tasks, stop the retained |
Preserve the retained daemon container so later resumes can restart it; only stop it so a failed resume does not leave the privileged daemon running.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Follow-up for review findings on #351 (release promote). Fixes are opening against
developrather than the frozen release branch.Why this PR exists
What changed
Fixes the seven open review findings from the v1.0.0 promote PR (#351), landed on
developso they can ship independently of the release branch:roomoteprefix.docker startit.R_APP_URLstill redirect users to a reachable callback.How it was tested
pnpm --filter @roomote/apiGiteahandleCommenttests (including non-roomote-prefix deployment identity)pnpm --filter @roomote/dbinstance-reportpure + isolation testspnpm --filter @roomote/sdksource-control pull-request reads tests, including OAuth Bearer listingtsc --noEmit/ pre-push typecheck for controller and related packagesChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset