[Feat] Show visual proof images inline in the task transcript#349
Merged
mrubens merged 6 commits intoJul 15, 2026
Merged
Conversation
Render manage_artifacts visual-proof upload results as always-visible previews under the tool row, preferring fresh session artifact thumbnails.
Memoize session artifacts so hook dependency arrays stay stable.
Keep knip clean for the inline transcript preview helpers.
Contributor
Author
|
No new code issues found. See task
Reviewed 99a8dff |
Cap previews at 100px, open the in-app artifact detail from viewUrl path, and keep the chat chrome image-only.
Proof-runner delegation uploads screenshots through manage_artifacts inside the subagent session, so the transcript only carries the spawn's terminal tool_result — a text blob with artifact viewUrls in prose, not the structured upload JSON the inline preview matched on. Recover those viewUrls from settled subagent results and resolve them against the session artifact list, which supplies fresh signed thumbnail/preview URLs instead of the blob's expiring rawUrl. Also fix the preview never loading on fresh page loads (loading="lazy" inside a zero-height button never intersects, so the image never started), and give the preview button a pointer cursor.
Only take the visual-proof preview path when media can render, and show a clickable filename chip for non-image proofs with a resolvable path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal product request from Slack (no GitHub issue): show captured visual proof inline in the web task transcript next to the capture/upload step.
Why this PR exists
What changed
Successful
manage_artifactsuploads withartifactType: "visual-proof"now render an always-visible, image-only preview under that tool row in the web task transcript.viewUrl)Why this change was made
Visual proof already landed in the Artifacts panel, but the center transcript only showed the tool steps as text. Reviewers wanted the screenshot itself next to the capture/upload step so the stream is self-explanatory, with a compact in-chat treatment that deep-links to the artifact detail surface.
Impact
Users reviewing a task on the web see compact visual-proof images inline under the matching upload tool result and can open the full artifact detail from that thumbnail. Artifacts panel behavior stays the same. Non-proof uploads and ordinary tools are unchanged.
How it was tested
viewUrl, always-visible preview rendering, and click-through to artifact detail: 23 passedlint:fast,check-types:fast, and knip passed for the branchChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset