Skip to content

[Feat] Show visual proof images inline in the task transcript#349

Merged
mrubens merged 6 commits into
developfrom
feature/inline-visual-proof-transcript-0lul4lkrx1411
Jul 15, 2026
Merged

[Feat] Show visual proof images inline in the task transcript#349
mrubens merged 6 commits into
developfrom
feature/inline-visual-proof-transcript-0lul4lkrx1411

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

Internal product request from Slack (no GitHub issue): show captured visual proof inline in the web task transcript next to the capture/upload step.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Successful manage_artifacts uploads with artifactType: "visual-proof" now render an always-visible, image-only preview under that tool row in the web task transcript.

  • Previews are capped at 100px tall in chat
  • Clicking the image opens the in-app Artifacts detail view for that artifact (path/version from session or upload viewUrl)
  • Chat chrome is the clickable image only (no external open fallback, no link/download row)

Why this change was made

Visual proof already landed in the Artifacts panel, but the center transcript only showed the tool steps as text. Reviewers wanted the screenshot itself next to the capture/upload step so the stream is self-explanatory, with a compact in-chat treatment that deep-links to the artifact detail surface.

Impact

Users reviewing a task on the web see compact visual-proof images inline under the matching upload tool result and can open the full artifact detail from that thumbnail. Artifacts panel behavior stays the same. Non-proof uploads and ordinary tools are unchanged.

How it was tested

  • Vitest unit/component coverage for visual-proof extraction, thumbnail vs rawUrl preference, path parsing from viewUrl, always-visible preview rendering, and click-through to artifact detail: 23 passed
  • Pre-push lint:fast, check-types:fast, and knip passed for the branch
  • Live browser screenshot for this preview remains blocked in this sandbox (no transcript with a visual-proof upload tool result)

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

mrubens added 3 commits July 14, 2026 23:56
Render manage_artifacts visual-proof upload results as always-visible previews under the tool row, preferring fresh session artifact thumbnails.
Memoize session artifacts so hook dependency arrays stay stable.
Keep knip clean for the inline transcript preview helpers.
@roomote-roomote

roomote-roomote Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

No new code issues found. See task

  • apps/web/src/app/(sandbox)/task/[taskId]/messages/acp/VisualProofToolPreview.tsx:64 - Direct non-image visual-proof uploads without a session artifact resolve to link, but this returns null while AcpToolMessage suppresses details. The transcript therefore shows a blank, non-clickable tool row; retain a clickable fallback or preserve the tool details.

Reviewed 99a8dff

mrubens added 3 commits July 15, 2026 02:56
Cap previews at 100px, open the in-app artifact detail from viewUrl path, and keep the chat chrome image-only.
Proof-runner delegation uploads screenshots through manage_artifacts
inside the subagent session, so the transcript only carries the spawn's
terminal tool_result — a text blob with artifact viewUrls in prose, not
the structured upload JSON the inline preview matched on. Recover those
viewUrls from settled subagent results and resolve them against the
session artifact list, which supplies fresh signed thumbnail/preview
URLs instead of the blob's expiring rawUrl.

Also fix the preview never loading on fresh page loads (loading="lazy"
inside a zero-height button never intersects, so the image never
started), and give the preview button a pointer cursor.
Only take the visual-proof preview path when media can render, and show a clickable filename chip for non-image proofs with a resolvable path.
@mrubens mrubens marked this pull request as ready for review July 15, 2026 03:56
@mrubens mrubens merged commit 97df2ac into develop Jul 15, 2026
17 checks passed
@mrubens mrubens deleted the feature/inline-visual-proof-transcript-0lul4lkrx1411 branch July 15, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant