[Improve] Collapse consecutive same-type completed tool calls in chat#317
Draft
roomote-roomote[bot] wants to merge 2 commits into
Draft
[Improve] Collapse consecutive same-type completed tool calls in chat#317roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Group identical tool types (including shell) into one multi-call entry once the second settled call completes, without mixing different tools.
Contributor
Author
|
1 issue outstanding. See task
Reviewed 81b63f1 |
Contributor
Author
|
Addressed all 3 open review items on this PR in
Validation: |
Polish generic group labels, drop the dead subagent display kind, and dedupe missing-toolCallId call/result pairs by payload signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — internal product cleanup requested over Slack.
Why this PR exists
What changed
Task conversation view now collapses consecutive same-type tool calls into one multi-call row after the second call settles (completed or failed). More same-type completions append into that group.
read_filevssearch_files, shell vs MCP).executecommands are included in the same collapsing path.Used 2 get issue calls,Edited 2 files).toolCallIdstill count once via payload signature.Toolshell andAcpGroupedToolMessage.How it was tested
pnpm --filter @roomote/web check-typestoolCallIdcases)lint:fast,check-types:fast,knipBrowser screenshots were not captured: no Storybook story for this component, and the seeded sandbox transcript does not reliably include enough consecutive completed same-type tools to show the collapsed UI honestly.
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset