[Chore] Superseded by provider-neutral reaction fix #1874 - #1906
[Chore] Superseded by provider-neutral reaction fix #1874#1906roomote-roomote[bot] wants to merge 4 commits into
Conversation
|
No code issues found. See task
Reviewed 7764d81 |
|
Superseded by #1874. Commits |
| platformEventKind: 'external_input', | ||
| platformEventVisibility: 'optional', | ||
| platformEventTranscriptPayload: { externalInput: reactionInput }, | ||
| threadContext, |
There was a problem hiding this comment.
threadContext is passed here, but it is dropped before the model sees it on a cold/rebuilt session. currentMessageId remains slack-reaction:${event.event_ts}; buildSlackThreadPromptBlocks orders context with Number(message.ts) < Number(currentMessageTs), and the prefixed ID becomes NaN, so every fetched thread message is filtered out. Keep a sortable Slack timestamp for prompt-context ordering (while retaining a unique reaction turn ID if needed), and add a cold-session regression that asserts the generated prompt includes the prior thread message.
What changed
external_inputworkaround as superseded by the provider-neutral reaction-turn model in #1874.Why this change was made
PR #1874 already owns the correct semantic fix by classifying reactions as human turns with
inputKind: reactionacross Slack, Discord, Teams, and Telegram. Keeping #1906 would duplicate that work and retain a competing Slack-only platform-event contract.Impact
This pull request should be closed without merging. PR #1874 should remain the sole delivery vehicle after its merge conflicts are resolved and it receives human approval.
Related PRs