Skip to content

[Chore] Superseded by provider-neutral reaction fix #1874 - #1906

Closed
roomote-roomote[bot] wants to merge 4 commits into
developfrom
fix/slack-forward-reaction-0m1b84kuozwo7
Closed

[Chore] Superseded by provider-neutral reaction fix #1874#1906
roomote-roomote[bot] wants to merge 4 commits into
developfrom
fix/slack-forward-reaction-0m1b84kuozwo7

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Reverted both implementation commits from this pull request, leaving an empty net diff.
  • Marked this Slack-only external_input workaround as superseded by the provider-neutral reaction-turn model in #1874.

Why this change was made

PR #1874 already owns the correct semantic fix by classifying reactions as human turns with inputKind: reaction across Slack, Discord, Teams, and Telegram. Keeping #1906 would duplicate that work and retain a competing Slack-only platform-event contract.

Impact

This pull request should be closed without merging. PR #1874 should remain the sole delivery vehicle after its merge conflicts are resolved and it receives human approval.

Related PRs

  • Canonical reaction semantics: #1874

@roomote-community

roomote-community Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

  • Pass the reacted-to Slack thread context into Fast so arrow_forward approvals can be disambiguated. (packages/cloud-agents/src/server/fast-agent/fast-agent-prompt.ts:254)
  • Keep fetched Slack thread context in cold/rebuilt Fast prompts. (apps/api/src/handlers/slack/events/fast-agent-reaction.ts:124) — dismissed: the Slack thread-context implementation was reverted, leaving this PR with an empty net diff.

Reviewed 7764d81

Comment thread packages/cloud-agents/src/server/fast-agent/fast-agent-prompt.ts Outdated
@roomote-roomote

roomote-roomote Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #1874. Commits b8a66cc9 and 7764d817 revert both #1906 implementation commits, leaving an empty net diff. The cold/rebuilt ordering finding was specific to #1906’s removed Slack thread-fetch workaround. Recommendation: close #1906 without merging, resolve #1874’s merge conflicts, and land #1874 after human approval.

@roomote-roomote roomote-roomote Bot changed the title [Fix] Fast ignores forward-arrow approval on actionable Slack messages [Fix] Fast ignores contextual Slack reactions Aug 31, 2026
platformEventKind: 'external_input',
platformEventVisibility: 'optional',
platformEventTranscriptPayload: { externalInput: reactionInput },
threadContext,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

threadContext is passed here, but it is dropped before the model sees it on a cold/rebuilt session. currentMessageId remains slack-reaction:${event.event_ts}; buildSlackThreadPromptBlocks orders context with Number(message.ts) < Number(currentMessageTs), and the prefixed ID becomes NaN, so every fetched thread message is filtered out. Keep a sortable Slack timestamp for prompt-context ordering (while retaining a unique reaction turn ID if needed), and add a cold-session regression that asserts the generated prompt includes the prior thread message.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This finding is now moot because the Slack thread-fetch workaround and its synthetic-timestamp ordering path were fully reverted. PR #1906 has an empty net diff and is marked superseded by #1874, which owns the provider-neutral inputKind: reaction model.

@roomote-roomote roomote-roomote Bot changed the title [Fix] Fast ignores contextual Slack reactions [Chore] Superseded by provider-neutral reaction fix #1874 Aug 31, 2026
@roomote-roomote roomote-roomote Bot closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant