[Fix] Slack Fast threads remain titled Thread after completed answers - #1884
Draft
roomote-roomote[bot] wants to merge 2 commits into
Draft
[Fix] Slack Fast threads remain titled Thread after completed answers#1884roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
| // A generated title is reported only after it has been persisted. Rename | ||
| // directly so short turns and status responses without a title cannot | ||
| // suppress the corresponding Slack notification. | ||
| void syncTitle(false); |
Contributor
There was a problem hiding this comment.
When a turn settles before the 300 ms timer, settle() cancels the only setAgentSessionStatus call, so there is no Slack agent session to rename. A generated title arriving afterward reaches this direct rename, receives false for the missing session, and has no later status update to trigger the retry. This is the short-turn path the PR is meant to fix; create the session (or retain a retryable pending title) before treating that rename failure as terminal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
The existing rename path waited for delayed turn activity and required
agents.sessions.setStatusto report a mismatched title. A short first turn could settle before that activity started, so its asynchronously generated title persisted in Roomote without ever notifying Slack. Later turns below the next title checkpoint made no new persisted title change, and status responses that omitted the current title gave them no mismatch to repair.Impact
New Slack Fast threads can receive their generated title without requiring another message. The existing processing/active status lifecycle remains unchanged, while generated-title notifications no longer depend on its timing or response shape. Previously stuck threads are not renamed retroactively by unchanged later turns.