[Fix] Fast sessions expose internal platform events in Slack - #1820
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Fix] Fast sessions expose internal platform events in Slack#1820roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
![roomote-community[bot]](https://avatars.githubusercontent.com/u/211522643?s=60&v=4){kind=small}
|
|
||
| throwIfTurnCancelled(); | ||
| if (!closed) { | ||
| if (!closed && !platformEvent) { |
Contributor
There was a problem hiding this comment.
Required platform events can now be acknowledged as delivered without ever reaching the conversation. If the model returns final text instead of calling send_chat_reply, this path returns successfully with visibleUpdatePosted still false. The PR-feedback and conflict delivery wrappers then persist their delivery claims, so those required notifications are never retried or shown. Please make a required event without an explicit reply fail/retry (or otherwise provide a safe, intentional closeout).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fast platform-event turns no longer use the model's final text as a fallback chat reply. Platform events remain internal session inputs, while deliberate parent-authored replies and task/tool updates continue through their explicit delivery paths.
Regression coverage exercises every current platform-event type with escaped payload output, the literal payload form, deliberate parent replies, and all child lifecycle purposes.
Why this change was made
An internal child lifecycle event could be echoed by the model and posted literally into Slack when the final-text fallback ran. The session should own user-visible communication instead of exposing serialized event envelopes.
Impact
After this change is deployed, Slack threads no longer receive raw or escaped platform-event payloads. Fast parents can still publish intentional summaries and task updates, and child lifecycle messages continue to reach the parent session for orchestration. The currently running service still has the old fallback behavior, so live Slack verification requires this PR to be merged and deployed.