Skip to content

Feature/chat search navigation#12300

Draft
Milkyawaway wants to merge 2 commits intoRooCodeInc:mainfrom
Milkyawaway:feature/chat-search-navigation
Draft

Feature/chat search navigation#12300
Milkyawaway wants to merge 2 commits intoRooCodeInc:mainfrom
Milkyawaway:feature/chat-search-navigation

Conversation

@Milkyawaway
Copy link
Copy Markdown

@Milkyawaway Milkyawaway commented May 9, 2026

Related GitHub Issue

Closes issue #12252

Description

Fixes #12252

This PR improves the chat search experience in the webview.

Key changes:

  • Add a search icon at the title bar,users can search text in current task.
  • It will exclude non-visible or rendered-only content from chat search, including:
    • Mermaid / graph / flowchart source content
    • readFile / read_file tool ask content
    • reasoning messages
    • hidden markdown link destinations while keeping visible link text searchable

Test Procedure

Tested with Node 20.19.2.

Automated checks run:

pnpm --filter @roo-code/vscode-webview lint
pnpm --filter @roo-code/vscode-webview check-types
pnpm --dir webview-ui exec vitest run src/utils/__tests__/chatSearchText.spec.ts
pnpm --filter roo-cline check-types
pnpm --dir src exec vitest run services/checkpoints/__tests__/ShadowCheckpointService.spec.ts --testTimeout=120000 --hookTimeout=120000

Manual verification:

  • Opened chat search from the title bar search icon.
  • Confirmed the search bar appears below the task title.
  • Confirmed closing the search bar does not noticeably change normal chat scroll position.
  • Searched sample content.
  • Confirmed Mermaid / graph / flowchart source text is not included in results.
  • Confirmed visible markdown link labels remain searchable while hidden link destinations are not.
  • Confirmed moving between already-visible matches only changes the active highlight and does not scroll.
  • Confirmed jumping to offscreen matches uses direct positioning.

Note: full pnpm test still hits the existing default 20s timeout in services/checkpoints/__tests__/ShadowCheckpointService.spec.ts on this machine. The same checkpoint test file passes when run directly with a longer Vitest timeout, as shown above.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

QQ截图20260509113031 屏幕截图 2026-05-09 113239

Documentation Updates

  • No documentation updates are required.
  • Yes, documentation updates are required. (Please describe what needs to be updated or link to a PR in the docs repository).

Get in Touch

Discord
ACDC
acdc0479_38706

Interactively review PR in Roo Code Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Add search functionality to the chat panel

1 participant