Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/api/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import OpenAI from "openai"

import { isRetiredProvider, type ProviderSettings, type ModelInfo } from "@roo-code/types"

import type { RooMessage } from "../core/task-persistence/rooMessage"

import { ApiStream } from "./transform/stream"

import {
Expand Down Expand Up @@ -91,7 +89,11 @@ export interface ApiHandlerCreateMessageMetadata {
}

export interface ApiHandler {
createMessage(systemPrompt: string, messages: RooMessage[], metadata?: ApiHandlerCreateMessageMetadata): ApiStream
createMessage(
systemPrompt: string,
messages: Anthropic.Messages.MessageParam[],
metadata?: ApiHandlerCreateMessageMetadata,
): ApiStream

getModel(): { id: string; info: ModelInfo }

Expand Down
12 changes: 3 additions & 9 deletions src/api/providers/__tests__/anthropic-vertex.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { RooMessage } from "../../../core/task-persistence/rooMessage"
// npx vitest run src/api/providers/__tests__/anthropic-vertex.spec.ts

import { AnthropicVertexHandler } from "../anthropic-vertex"
Expand Down Expand Up @@ -185,7 +184,7 @@ describe("AnthropicVertexHandler", () => {
})

describe("createMessage", () => {
const mockMessages: RooMessage[] = [
const mockMessages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Hello",
Expand Down Expand Up @@ -245,20 +244,15 @@ describe("AnthropicVertexHandler", () => {
)
})

it("should pass messages directly to streamText as ModelMessage[]", async () => {
it("should call convertToAiSdkMessages with the messages", async () => {
mockStreamText.mockReturnValue(createMockStreamResult([]))

const stream = handler.createMessage(systemPrompt, mockMessages)
for await (const _chunk of stream) {
// consume
}

// Messages are now already in ModelMessage format, passed directly to streamText
expect(mockStreamText).toHaveBeenCalledWith(
expect.objectContaining({
messages: mockMessages,
}),
)
expect(convertToAiSdkMessages).toHaveBeenCalledWith(mockMessages)
})

it("should pass tools through AI SDK conversion pipeline", async () => {
Expand Down
5 changes: 2 additions & 3 deletions src/api/providers/__tests__/azure.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { RooMessage } from "../../../core/task-persistence/rooMessage"
// Use vi.hoisted to define mock functions that can be referenced in hoisted vi.mock() calls
const { mockStreamText, mockGenerateText, mockCreateAzure } = vi.hoisted(() => ({
mockStreamText: vi.fn(),
Expand Down Expand Up @@ -133,7 +132,7 @@ describe("AzureHandler", () => {

describe("createMessage", () => {
const systemPrompt = "You are a helpful assistant."
const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [
Expand Down Expand Up @@ -377,7 +376,7 @@ describe("AzureHandler", () => {

describe("tools", () => {
const systemPrompt = "You are a helpful assistant."
const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [{ type: "text" as const, text: "Use a tool" }],
Expand Down
3 changes: 1 addition & 2 deletions src/api/providers/__tests__/base-provider.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { RooMessage } from "../../../core/task-persistence/rooMessage"
import { Anthropic } from "@anthropic-ai/sdk"

import type { ModelInfo } from "@roo-code/types"
Expand All @@ -8,7 +7,7 @@ import type { ApiStream } from "../../transform/stream"

// Create a concrete implementation for testing
class TestProvider extends BaseProvider {
createMessage(_systemPrompt: string, _messages: RooMessage[]): ApiStream {
createMessage(_systemPrompt: string, _messages: Anthropic.Messages.MessageParam[]): ApiStream {
throw new Error("Not implemented")
}

Expand Down
7 changes: 3 additions & 4 deletions src/api/providers/__tests__/baseten.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { RooMessage } from "../../../core/task-persistence/rooMessage"
// npx vitest run src/api/providers/__tests__/baseten.spec.ts

// Use vi.hoisted to define mock functions that can be referenced in hoisted vi.mock() calls
Expand Down Expand Up @@ -102,7 +101,7 @@ describe("BasetenHandler", () => {

describe("createMessage", () => {
const systemPrompt = "You are a helpful assistant."
const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [
Expand Down Expand Up @@ -282,7 +281,7 @@ describe("BasetenHandler", () => {

describe("tool handling", () => {
const systemPrompt = "You are a helpful assistant."
const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [{ type: "text" as const, text: "Hello!" }],
Expand Down Expand Up @@ -390,7 +389,7 @@ describe("BasetenHandler", () => {

describe("error handling", () => {
const systemPrompt = "You are a helpful assistant."
const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [{ type: "text" as const, text: "Hello!" }],
Expand Down
48 changes: 28 additions & 20 deletions src/api/providers/__tests__/bedrock.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { RooMessage } from "../../../core/task-persistence/rooMessage"
// Mock TelemetryService before other imports
const mockCaptureException = vi.fn()

Expand Down Expand Up @@ -491,14 +490,17 @@ describe("AwsBedrockHandler", () => {
it("should properly pass image content through to streamText via AI SDK messages", async () => {
setupMockStreamText()

const messages: any[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [
{
type: "image",
image: `data:image/jpeg;base64,${mockImageData}`,
mimeType: "image/jpeg",
source: {
type: "base64",
data: mockImageData,
media_type: "image/jpeg",
},
},
{
type: "text",
Expand Down Expand Up @@ -528,7 +530,7 @@ describe("AwsBedrockHandler", () => {
expect(userMsg).toBeDefined()
expect(Array.isArray(userMsg.content)).toBe(true)

// Messages are already in AI SDK ImagePart format
// The AI SDK convertToAiSdkMessages converts images to { type: "image", image: "data:...", mimeType: "..." }
const imagePart = userMsg.content.find((p: { type: string }) => p.type === "image")
expect(imagePart).toBeDefined()
expect(imagePart.image).toContain("data:image/jpeg;base64,")
Expand All @@ -542,23 +544,29 @@ describe("AwsBedrockHandler", () => {
it("should handle multiple images in a single message", async () => {
setupMockStreamText()

const messages: any[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [
{
type: "image",
image: `data:image/jpeg;base64,${mockImageData}`,
mimeType: "image/jpeg",
source: {
type: "base64",
data: mockImageData,
media_type: "image/jpeg",
},
},
{
type: "text",
text: "First image",
},
{
type: "image",
image: `data:image/png;base64,${mockImageData}`,
mimeType: "image/png",
source: {
type: "base64",
data: mockImageData,
media_type: "image/png",
},
},
{
type: "text",
Expand Down Expand Up @@ -753,7 +761,7 @@ describe("AwsBedrockHandler", () => {
awsBedrock1MContext: true,
})

const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Test message",
Expand Down Expand Up @@ -786,7 +794,7 @@ describe("AwsBedrockHandler", () => {
awsBedrock1MContext: false,
})

const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Test message",
Expand Down Expand Up @@ -820,7 +828,7 @@ describe("AwsBedrockHandler", () => {
awsBedrock1MContext: true,
})

const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Test message",
Expand Down Expand Up @@ -873,7 +881,7 @@ describe("AwsBedrockHandler", () => {
awsBedrock1MContext: true,
})

const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Test message",
Expand Down Expand Up @@ -1005,7 +1013,7 @@ describe("AwsBedrockHandler", () => {
awsBedrockServiceTier: "PRIORITY",
})

const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Test message",
Expand Down Expand Up @@ -1042,7 +1050,7 @@ describe("AwsBedrockHandler", () => {
awsBedrockServiceTier: "FLEX",
})

const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Test message",
Expand Down Expand Up @@ -1079,7 +1087,7 @@ describe("AwsBedrockHandler", () => {
awsBedrockServiceTier: "PRIORITY", // Try to apply PRIORITY tier
})

const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Test message",
Expand Down Expand Up @@ -1114,7 +1122,7 @@ describe("AwsBedrockHandler", () => {
// No awsBedrockServiceTier specified
})

const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Test message",
Expand Down Expand Up @@ -1184,7 +1192,7 @@ describe("AwsBedrockHandler", () => {
awsRegion: "us-east-1",
})

const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Hello",
Expand Down Expand Up @@ -1259,7 +1267,7 @@ describe("AwsBedrockHandler", () => {
awsRegion: "us-east-1",
})

const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Hello",
Expand Down
7 changes: 3 additions & 4 deletions src/api/providers/__tests__/deepseek.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { RooMessage } from "../../../core/task-persistence/rooMessage"
// Use vi.hoisted to define mock functions that can be referenced in hoisted vi.mock() calls
const { mockStreamText, mockGenerateText } = vi.hoisted(() => ({
mockStreamText: vi.fn(),
Expand Down Expand Up @@ -174,7 +173,7 @@ describe("DeepSeekHandler", () => {

describe("createMessage", () => {
const systemPrompt = "You are a helpful assistant."
const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [
Expand Down Expand Up @@ -401,7 +400,7 @@ describe("DeepSeekHandler", () => {

describe("reasoning content with deepseek-reasoner", () => {
const systemPrompt = "You are a helpful assistant."
const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [
Expand Down Expand Up @@ -571,7 +570,7 @@ describe("DeepSeekHandler", () => {

describe("tool handling", () => {
const systemPrompt = "You are a helpful assistant."
const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [{ type: "text" as const, text: "Hello!" }],
Expand Down
5 changes: 2 additions & 3 deletions src/api/providers/__tests__/fireworks.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { RooMessage } from "../../../core/task-persistence/rooMessage"
// npx vitest run src/api/providers/__tests__/fireworks.spec.ts

// Use vi.hoisted to define mock functions that can be referenced in hoisted vi.mock() calls
Expand Down Expand Up @@ -364,7 +363,7 @@ describe("FireworksHandler", () => {

describe("createMessage", () => {
const systemPrompt = "You are a helpful assistant."
const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [
Expand Down Expand Up @@ -731,7 +730,7 @@ describe("FireworksHandler", () => {

describe("tool handling", () => {
const systemPrompt = "You are a helpful assistant."
const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: [{ type: "text" as const, text: "Hello!" }],
Expand Down
5 changes: 2 additions & 3 deletions src/api/providers/__tests__/gemini.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { RooMessage } from "../../../core/task-persistence/rooMessage"
// npx vitest run src/api/providers/__tests__/gemini.spec.ts

import { NoOutputGeneratedError } from "ai"
Expand Down Expand Up @@ -103,7 +102,7 @@ describe("GeminiHandler", () => {
})

describe("createMessage", () => {
const mockMessages: RooMessage[] = [
const mockMessages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Hello",
Expand Down Expand Up @@ -378,7 +377,7 @@ describe("GeminiHandler", () => {
})

describe("error telemetry", () => {
const mockMessages: RooMessage[] = [
const mockMessages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Hello",
Expand Down
3 changes: 1 addition & 2 deletions src/api/providers/__tests__/lite-llm.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { RooMessage } from "../../../core/task-persistence/rooMessage"
const { mockStreamText, mockGenerateText } = vi.hoisted(() => ({
mockStreamText: vi.fn(),
mockGenerateText: vi.fn(),
Expand Down Expand Up @@ -258,7 +257,7 @@ describe("LiteLLMHandler", () => {
})

const systemPrompt = "You are a helpful assistant"
const messages: RooMessage[] = [{ role: "user", content: "Hello" }]
const messages: Anthropic.Messages.MessageParam[] = [{ role: "user", content: "Hello" }]

const generator = handler.createMessage(systemPrompt, messages)
for await (const _chunk of generator) {
Expand Down
3 changes: 1 addition & 2 deletions src/api/providers/__tests__/lmstudio.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { RooMessage } from "../../../core/task-persistence/rooMessage"
// Use vi.hoisted to define mock functions that can be referenced in hoisted vi.mock() calls
const { mockStreamText, mockGenerateText, mockWrapLanguageModel } = vi.hoisted(() => ({
mockStreamText: vi.fn(),
Expand Down Expand Up @@ -61,7 +60,7 @@ describe("LmStudioHandler", () => {

describe("createMessage", () => {
const systemPrompt = "You are a helpful assistant."
const messages: RooMessage[] = [
const messages: Anthropic.Messages.MessageParam[] = [
{
role: "user",
content: "Hello!",
Expand Down
Loading
Loading