-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: add PR workflow to build regular and nightly VSIX artifacts #11376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This file should be moved to .github/workflows/pr-build.yml The roomote bot token lacks the workflows permission to push directly to .github/workflows/.
Both previously flagged issues are resolved in 273203e. No new issues found.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
.github/pr-build.yml
Outdated
| const { data: comments } = await github.rest.issues.listComments({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: context.issue.number, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listComments returns 30 results per page by default. On PRs with more than 30 comments, the bot's earlier comment won't appear in the first page, so comments.find(...) won't match it and a duplicate comment will be created instead of updating the existing one. Set per_page: 100 and use github.paginate (or the paginate.iterator) to walk all pages.
| const { data: comments } = await github.rest.issues.listComments({ | |
| owner: context.repo.owner, | |
| repo: context.repo.repo, | |
| issue_number: context.issue.number, | |
| }); | |
| const comments = await github.paginate(github.rest.issues.listComments, { | |
| owner: context.repo.owner, | |
| repo: context.repo.repo, | |
| issue_number: context.issue.number, | |
| per_page: 100, | |
| }); |
Fix it with Roo Code or mention @roomote and request a fix.
.github/pr-build.yml
Outdated
| - name: Determine VSIX filename | ||
| id: vsix | ||
| run: | | ||
| VSIX_FILE=$(ls bin/*.vsix | head -n1) | ||
| VSIX_NAME=$(basename "$VSIX_FILE") | ||
| echo "file=$VSIX_FILE" >> "$GITHUB_OUTPUT" | ||
| echo "name=$VSIX_NAME" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step sets steps.vsix.outputs.file and steps.vsix.outputs.name, but no subsequent step references either output. The upload step uses a glob pattern directly. Consider removing this dead step to reduce noise.
Fix it with Roo Code or mention @roomote and request a fix.
|
@roomote can you assess if the comments/suggestions are legit? If so, address them. |
Fixed both review issues: removed the dead "Determine VSIX filename" step and replaced |
- Remove unused "Determine VSIX filename" step whose outputs were never consumed - Replace listComments with github.paginate to handle PRs with 30+ comments
Summary
Adds a new GitHub Actions workflow that automatically builds both regular and nightly VSIX packages on every pull request, uploads them as downloadable artifacts, and posts a PR comment with download links.
This gives reviewers a one-click path to install and test PR changes locally before merging.
Reviewer action required
The workflow file is staged at
.github/pr-build.ymlbecause the automation token lacks theworkflowspermission needed to push to.github/workflows/. A maintainer needs to move the file:What the workflow does
pull_requestevents (opened, reopened, ready_for_review, synchronize) targetingmainpnpm vsixto produce the standard marketplace VSIXpnpm vsix:nightlyHow reviewers use it
After the workflow runs, a comment appears on the PR:
Reviewers click the link, download the
.vsix, and install with:View task on Roo Code Cloud
Important
Adds a GitHub Actions workflow to build and upload regular and nightly VSIX packages on pull request events, with download links posted in PR comments.
.github/pr-build.ymlfor building VSIX packages onpull_requestevents targetingmain.build-regular: Runspnpm vsixto build regular VSIX and uploads it asroo-code.build-nightly: Patches version inpackage.nightly.json, runspnpm vsix:nightly, and uploads asroo-code-nightly.comment: Posts or updates a PR comment with download links for both artifacts..github/workflows/by a maintainer.This description was created by
for 273203e. You can customize this summary. It will automatically update as commits are pushed.