Skip to content

Conversation

@DangerMouseUK
Copy link
Contributor

@DangerMouseUK DangerMouseUK commented Feb 10, 2026

This fixes an automated edit that reintroduced a fallback which then caused the Azure Foundry endpoint to fail.

This has now been set to more frequently send v1 when the api-version is blank which is now the expected version.


Important

Fix Azure Foundry endpoint by omitting apiVersion when blank in AzureHandler.

  • Behavior:
    • In AzureHandler in azure.ts, omit apiVersion when the configured value is blank.
    • Update createAzure call to not include apiVersion if blank.
  • Tests:
    • Update azure.spec.ts to reflect changes in AzureHandler behavior.
    • Modify tests to check for absence of apiVersion when blank.
    • Change test descriptions to match new behavior.

This description was created by Ellipsis for ab1f1a1. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Feb 10, 2026
@roomote
Copy link
Contributor

roomote bot commented Feb 10, 2026

Rooviewer Clock   See task

All previously flagged issues have been addressed. No new issues found.

  • Stale test description on line 77 of azure.spec.ts -- says "should use default API version" but the assertion now checks that apiVersion is omitted
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

expect(handlerWithoutVersion).toBeInstanceOf(AzureHandler)
expect(mockCreateAzure).toHaveBeenLastCalledWith(
expect.objectContaining({ apiVersion: "2025-04-01-preview" }),
expect.not.objectContaining({ apiVersion: expect.anything() }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test description on line 77 still says "should use default API version if not provided" but this assertion now verifies that apiVersion is omitted. The analogous test on line 101 was renamed to "should omit API version when configured value is blank" -- line 77 should get the same treatment for consistency (e.g. "should omit API version if not provided").

Fix it with Roo Code or mention @roomote and request a fix.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 10, 2026
@hannesrudolph hannesrudolph merged commit 4438fda into RooCodeInc:main Feb 10, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Feb 10, 2026
@DangerMouseUK DangerMouseUK deleted the fix/pr-11144 branch February 11, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants