-
Notifications
You must be signed in to change notification settings - Fork 48
New subscription for phpunit #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
src/Support/PHPUnit/EventSubscribers/SwaggerSaveDocumentationSubscriber.php
Outdated
Show resolved
Hide resolved
src/Support/PHPUnit/EventSubscribers/SwaggerSaveDocumentationSubscriber.php
Outdated
Show resolved
Hide resolved
1c0fdb9 to
69a7503
Compare
daff349 to
e926dc5
Compare
|
|
Hi @DenTray, what should I do to get this PR done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new PHPUnit event subscriber to automatically save Swagger documentation after all tests are executed and updates the README with improved documentation. The changes simplify the integration by removing Laravel application bootstrapping logic and providing better setup instructions for developers.
- Removes manual Laravel application bootstrapping from the PHPUnit subscriber
- Updates README with clearer installation steps and configuration examples
- Improves documentation formatting and clarity throughout
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Support/PHPUnit/EventSubscribers/SwaggerSaveDocumentationSubscriber.php | Simplifies the subscriber by removing Laravel bootstrap logic and unused imports |
| README.md | Enhances documentation with better formatting, clearer instructions, and improved language |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
# Conflicts: # src/Support/PHPUnit/EventSubscribers/SwaggerSaveDocumentationSubscriber.php
e926dc5 to
76b77de
Compare
|



Hello, everyone. The
FinishedSubscriberwill be called after every test, but theExecutionFinishedSubscriberwill be called after all tests are executed.Also, by adding this extension to the
phpunit.xmlfile, this process can be done automatically, which would be great for devs who don't need to concern themselves with calling this command after every test run.Also, I updated the README file to make more complete the information described.