Repository navigation
Move Identification model to models_future - #1515
Merged
Merged
Conversation
✅ Deploy Preview for antenna-preview canceled.
|
Contributor
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Model extraction and lifecycle ami/main/models.py, ami/main/models_future/identifications.py |
Identification is now defined in models_future.identifications and re-exported from models.py. Its relationships, lifecycle behavior, and permission checks are defined in the new module. Related-model imports are localized. |
Identification endpoint test coverage ami/main/models_future/tests/test_identifications.py, ami/main/tests.py |
The dedicated test module covers single and bulk identification behavior, validation, permissions, partial failures, and query scaling. The corresponding tests and unused imports were removed from ami/main/tests.py. |
Taxonomy QuerySet Method
| Layer / File(s) | Summary |
|---|---|
Remove with_children() ami/main/models_future/taxonomy.py |
TaxonQuerySet.with_children() was removed. Commented example code retains parts of its former query construction. |
Priority:
Estimated code review effort: 3 (Moderate) | ~25 minutes
Change: Refactor
Merge Risk: 
14803
-
No actionable issue remains; the change is ready to merge after normal checks.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly describes the main change: moving the Identification model to models_future. Description check The description summarizes the model and test move, references the related issue, and reports the test result. It omits the template’s detailed description, deployment notes, and checklist, but the co… Docstring Coverage Docstring coverage is inconclusive: files from earlier reviews still need to be rechecked within the check's analysis limits. Not blocking. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description summarizes the model and test move, references the related issue, and reports the test result. It omits the template’s detailed description, deployment notes, and checklist, but the core change and testing information are clear.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
kra
force-pushed
the
kra/model-taxonomy-identification-prep-move
branch
from
October 21, 2026 18:59
875d361 to
e2688ef
Compare
✅ Deploy Preview for antenna-ssec canceled.
|
Base automatically changed from
kra/model-taxonomy-identification-prep
to
main
October 22, 2026 18:52
mihow
reviewed
Oct 22, 2026
mihow
approved these changes
Oct 28, 2026
Small cleanups in test_identification.py and tests.py.
kra
force-pushed
the
kra/model-taxonomy-identification-prep-move
branch
from
October 29, 2026 18:28
e2688ef to
14803c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moved Identification and tests to models_future.
Small cleanups in test_identification.py and tests.py.
Related Issues
Relates to #260.
How to Test the Changes
Unit tests pass, although I didn't check coverage.
Summary by CodeRabbit