This repository was archived by the owner on Oct 30, 2022. It is now read-only.
Issue #14: team-05 - Simulate until rocket is out of rail#98
Open
GustavoSaturnino wants to merge 1 commit intoRocketPy-Team:masterfrom
Open
Issue #14: team-05 - Simulate until rocket is out of rail#98GustavoSaturnino wants to merge 1 commit intoRocketPy-Team:masterfrom
GustavoSaturnino wants to merge 1 commit intoRocketPy-Team:masterfrom
Conversation
GustavoSaturnino
changed the title
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Important addition to run Out of Rail Speed as a Function of Mass analysis faster! I've tested and approved the PR with only one minor change suggested, good job!
| self.solution[-1] = [self.t, *self.state] | ||
| # Set last flight phase | ||
| self.flightPhases.flushAfter(phase_index) | ||
| print(self.t) |
Member
There was a problem hiding this comment.
Suggested change
| print(self.t) |
Gui-FernandesBR
changed the title
Member
|
May recieve an extra 20% points since it was the onlly team solving this challege |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've changed "Flight" to TerminateOnRail works.
Attention to "Flight Trajectory" graph.