Issue #53: team-02 - Openrocket Integration#109
Issue #53: team-02 - Openrocket Integration#109smkinney979 wants to merge 3 commits intoRocketPy-Team:masterfrom
Conversation
Added a variety of utility functions to assist with parsing .ork files to create RocketPy simulations
|
Wow!! This is awesome!! |
|
@smkinney979, what a great job! Reading OpenRocket files is not easy, and converting them into RocketPy classes is even more of a challenge. Thanks for submitting a working example, even if not complete (such as the missing motor). I can see you worked quite hard to get this working and thus deserve a lot of points. Unfortunately, since the complete task was not satisfied, I cannot award you 100% score for this hard problem. But I can gladly give you the points equivalent to a medium challenge. I am sure with a bit more time we can get this complete and ready to ship with the next version of RocketPy! I expect many more amazing contributions from you. |
|
May recieve an extra 20% points since it was the onlly team solving this challege |
Hackathon PR for #53 from Team 02 Read the .ork
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
ReadMe, Docs and GitHub maintenance:
Code base maintenance (refactoring, formatting, renaming):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyCode base additions (for bug fixes / features):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
Enter text here...
What is the new behavior?
Feature to import parameters from OpenRocket .ork files. The file ork_testing.py will run the user through an example of how this new feature can be used. All feature functions are in utilities.py. There are a variety of comments through the functions and ork_testing.py that explain certain design decisions for a variety of the functions.
Note: ork_testing.py uses an amalgamation of .eng and drag curve files, so the trajectory generated by the flight is a little weird but is only for testing purposes.
Does this introduce a breaking change?
Other information
NA