This repository was archived by the owner on Oct 30, 2022. It is now read-only.
Issue #66: team-01 - Simulated Midnight Sun using getting_started notebook file#101
Open
aasitvora99 wants to merge 1 commit intoRocketPy-Team:masterfrom
Open
Issue #66: team-01 - Simulated Midnight Sun using getting_started notebook file#101aasitvora99 wants to merge 1 commit intoRocketPy-Team:masterfrom
aasitvora99 wants to merge 1 commit intoRocketPy-Team:masterfrom
Conversation
Open
Gui-FernandesBR
approved these changes
Aug 28, 2022
Member
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
For me it's approved, @FranzYuri add your review as well!
FranzYuri
approved these changes
Aug 28, 2022
Member
|
Good implementation, with more then requested by the challenge itself. Thank you @aasitvora99 for your first contribution, we are adding extra 20% for this pull requested :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
ReadMe, Docs and GitHub maintenance:
Code base maintenance (refactoring, formatting, renaming):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyCode base additions (for bug fixes / features):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
Enter text here...
What is the new behavior?
Enter text here...
Does this introduce a breaking change?
Other information
Enter text here...