fix: unhandled promise rejection when pinning a message fails#41576
Open
priyadarshi7 wants to merge 1 commit into
Open
fix: unhandled promise rejection when pinning a message fails#41576priyadarshi7 wants to merge 1 commit into
priyadarshi7 wants to merge 1 commit into
Conversation
`usePinMessageAction` destructured `mutateAsync` from `usePinMessageMutation` but never awaited the returned promise. Unlike `mutate`, `mutateAsync` rejects when the request fails, so a failed pin surfaced as an "Uncaught (in promise)" error even though the failure was already handled. The mutation owns the full lifecycle through its callbacks: `onMutate` applies the optimistic pin, `onError` rolls it back and dispatches the error toast, and `onSettled` invalidates the pinned messages query. The promise result is therefore unused. Switch to `mutate`, which returns `void` and accepts the same arguments, so behaviour is unchanged and the hook now matches its sibling `useUnpinMessageAction`, which already uses `mutate`.
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 34c1e54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx,js}📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
Files:
🧠 Learnings (3)📚 Learning: 2026-03-16T21:50:37.589ZApplied to files:
📚 Learning: 2026-03-27T14:52:56.865ZApplied to files:
📚 Learning: 2026-05-06T12:21:44.083ZApplied to files:
🔇 Additional comments (2)
WalkthroughThe pin message action now invokes the mutation without awaiting its result, preventing rejected pin operations from producing unhandled promise rejections. A patch changeset documents the fix for ChangesPin message rejection handling
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usePinMessageActiondestructuredmutateAsyncfromusePinMessageMutationbut never awaited the returned promise. Unlikemutate,mutateAsyncrejects when the request fails, so a failed pin surfaced as an "Uncaught (in promise)" error even though the failure was already handled.The mutation owns the full lifecycle through its callbacks:
onMutateapplies the optimistic pin,onErrorrolls it back and dispatches the error toast, andonSettledinvalidates the pinned messages query. The promise result is therefore unused.Switch to
mutate, which returnsvoidand accepts the same arguments, so behaviour is unchanged and the hook now matches its siblinguseUnpinMessageAction, which already usesmutate.Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit