Skip to content

i18n: refine room toolbox layout labels and descriptions#41556

Open
TheRazorbill wants to merge 1 commit into
RocketChat:feat/GSoC-2026-room-header-projectfrom
TheRazorbill:feat/GSoC-2026-room-header-project
Open

i18n: refine room toolbox layout labels and descriptions#41556
TheRazorbill wants to merge 1 commit into
RocketChat:feat/GSoC-2026-room-header-projectfrom
TheRazorbill:feat/GSoC-2026-room-header-project

Conversation

@TheRazorbill

@TheRazorbill TheRazorbill commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Shortens and clarifies the labels and descriptions for the per-scope room toolbox layout settings (Room_Toolbox_Layout_Public, Room_Toolbox_Layout_Private, Room_Toolbox_Layout_Direct) in en.i18n.json and pt-BR.i18n.json, per design feedback. Also adds a hint that negative maxVisibleNormal values are treated as 0.

Review in cubic

Summary by CodeRabbit

  • Documentation
    • Clarified English and Brazilian Portuguese labels for room toolbox layouts.
    • Added specific guidance for public, private, and direct-room configurations.
    • Documented how maxVisibleNormal affects visible versus overflow actions, including that 0 moves all normal actions to overflow and negative values are treated as 0.

Copilot AI review requested due to automatic review settings July 24, 2026 20:05
@dionisio-bot

dionisio-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: da5d3bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc676e3e-cca9-42f0-a64d-3655a79f52df

📥 Commits

Reviewing files that changed from the base of the PR and between f652e5e and da5d3bd.

📒 Files selected for processing (2)
  • packages/i18n/src/locales/en.i18n.json
  • packages/i18n/src/locales/pt-BR.i18n.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/i18n/src/locales/en.i18n.json
📜 Recent review details
🔇 Additional comments (1)
packages/i18n/src/locales/pt-BR.i18n.json (1)

4659-4664: LGTM!


Walkthrough

Updated English and Brazilian Portuguese room toolbox layout labels and descriptions to identify public, private, and direct room types and explain maxVisibleNormal visibility behavior.

Changes

Room toolbox localization

Layer / File(s) Summary
Localized toolbox descriptions
packages/i18n/src/locales/en.i18n.json, packages/i18n/src/locales/pt-BR.i18n.json
Room-specific labels and descriptions now reference JSON types c, p, and d, and document how maxVisibleNormal controls visible actions, including negative-value handling.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: type: chore

Suggested reviewers: dougfabris, gabriellsh, abhinavkrin

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: refined i18n labels and descriptions for the room toolbox layout.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • GSOC-2026: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/i18n/src/locales/en.i18n.json`:
- Line 4788: Update the descriptions for Room_Toolbox_Layout_Public_description
and the corresponding entries at the referenced nearby keys to clarify that
maxVisibleNormal: 0 moves normal actions into overflow while featured actions
remain visible; remove the misleading statement that it hides all actions.

In `@packages/i18n/src/locales/pt-BR.i18n.json`:
- Line 4660: Update the Portuguese descriptions for
Room_Toolbox_Layout_Public_description and the corresponding entries at the
referenced locations to clarify that maxVisibleNormal: 0 hides normal actions
from the main toolbar/list only; featured actions may remain visible and
overflow actions remain available through hiddenActions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2707361d-b77b-4dff-b3f7-5972b6974e35

📥 Commits

Reviewing files that changed from the base of the PR and between 5db8bea and f652e5e.

📒 Files selected for processing (2)
  • packages/i18n/src/locales/en.i18n.json
  • packages/i18n/src/locales/pt-BR.i18n.json
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: cubic · AI code reviewer
🔇 Additional comments (2)
packages/i18n/src/locales/en.i18n.json (1)

4787-4787: LGTM!

Also applies to: 4789-4789, 4791-4791

packages/i18n/src/locales/pt-BR.i18n.json (1)

4659-4659: LGTM!

Also applies to: 4661-4661, 4663-4663

Comment thread packages/i18n/src/locales/en.i18n.json Outdated
Comment thread packages/i18n/src/locales/pt-BR.i18n.json Outdated
@TheRazorbill
TheRazorbill force-pushed the feat/GSoC-2026-room-header-project branch from f652e5e to da5d3bd Compare July 24, 2026 20:11

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread packages/i18n/src/locales/en.i18n.json Outdated
Comment thread packages/i18n/src/locales/pt-BR.i18n.json Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants