i18n: refine room toolbox layout labels and descriptions#41556
i18n: refine room toolbox layout labels and descriptions#41556TheRazorbill wants to merge 1 commit into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details🔇 Additional comments (1)
WalkthroughUpdated English and Brazilian Portuguese room toolbox layout labels and descriptions to identify public, private, and direct room types and explain ChangesRoom toolbox localization
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/i18n/src/locales/en.i18n.json`:
- Line 4788: Update the descriptions for Room_Toolbox_Layout_Public_description
and the corresponding entries at the referenced nearby keys to clarify that
maxVisibleNormal: 0 moves normal actions into overflow while featured actions
remain visible; remove the misleading statement that it hides all actions.
In `@packages/i18n/src/locales/pt-BR.i18n.json`:
- Line 4660: Update the Portuguese descriptions for
Room_Toolbox_Layout_Public_description and the corresponding entries at the
referenced locations to clarify that maxVisibleNormal: 0 hides normal actions
from the main toolbar/list only; featured actions may remain visible and
overflow actions remain available through hiddenActions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2707361d-b77b-4dff-b3f7-5972b6974e35
📒 Files selected for processing (2)
packages/i18n/src/locales/en.i18n.jsonpackages/i18n/src/locales/pt-BR.i18n.json
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: cubic · AI code reviewer
🔇 Additional comments (2)
packages/i18n/src/locales/en.i18n.json (1)
4787-4787: LGTM!Also applies to: 4789-4789, 4791-4791
packages/i18n/src/locales/pt-BR.i18n.json (1)
4659-4659: LGTM!Also applies to: 4661-4661, 4663-4663
f652e5e to
da5d3bd
Compare
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Shortens and clarifies the labels and descriptions for the per-scope room toolbox layout settings (
Room_Toolbox_Layout_Public,Room_Toolbox_Layout_Private,Room_Toolbox_Layout_Direct) inen.i18n.jsonandpt-BR.i18n.json, per design feedback. Also adds a hint that negativemaxVisibleNormalvalues are treated as0.Summary by CodeRabbit
maxVisibleNormalaffects visible versus overflow actions, including that0moves all normal actions to overflow and negative values are treated as0.