regression: emoji bottom clipped in messages and announcement banner on Windows/Linux#41555
regression: emoji bottom clipped in messages and announcement banner on Windows/Linux#41555KevLehman wants to merge 1 commit into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (19)
🔇 Additional comments (1)
WalkthroughEmoji styling now uses a reduced line-height, with native message emojis given automatic dimensions to avoid glyph clipping. ChangesEmoji rendering
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Stylelint (17.14.0)apps/meteor/app/theme/client/imports/components/emoji.cssConfigurationError: Could not find "stylelint-order". Do you need to install the package or use the "configBasedir" option? Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.7.0 #41555 +/- ##
=================================================
- Coverage 68.61% 68.55% -0.07%
=================================================
Files 4138 4138
Lines 159416 159419 +3
Branches 28206 28154 -52
=================================================
- Hits 109384 109288 -96
- Misses 44893 44998 +105
+ Partials 5139 5133 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Native emoji glyphs render with their bottom cut off in message bodies and the room announcement banner on Windows (Segoe UI Emoji) and Linux (Noto Color Emoji). Not reproducible on macOS.
Two instances of the same root cause, introduced by the emojione removal (#39411):
.rcx-message__emojiforces a fixed1.5rembox (height/width/line-height), sized for the old sprite images. Native glyphs on Segoe/Noto paint taller and wider than that box (Noto ink ≈ 1.13em, advance ≈ 1.25em), and the overhang is clipped by.rcx-message-body'soverflow: hidden. Apple Color Emoji ink stops just inside the box, which is why macOS is unaffected. Fixed by letting the box grow to the glyph (width/height: auto,line-height: 1.2), scoped to exclude custom image emojis; unitless line-height also covers the--big(emoji-only) variant.MarkdownTextsurfaces):.emoji'sline-height: 1.5rem(24px) is smaller than the 22px-font glyph box, so the emoji overhangs the truncated banner Box'soverflow: hiddenby 1px on each side plus the ink below the baseline. Fixed byline-height: 1.2(26.4px), which contains the ink of all three platform emoji fonts.Verified with a Chromium repro using the real Noto Color Emoji font (clip reproduced, then gone with the fix) and against a live server (emoji boxes now fully contained by their
overflow: hiddenancestors; banner keeps its 40px height). Emoji picker, reactions, and thread previews pin their own line-heights and are unaffected. Lines containing an emoji grow ~2–5px, which is the space the glyph actually needs.Follow-up (not for this release): move the glyph-aware sizing and the emoji font-family stack into Fuselage's
MessageEmojiand drop these overrides fromemoji.css.Issue(s)
CORE-2433
Steps to test or reproduce
Further comments
CSS-only change. No changeset (regression fix targeting the release branch).
Windows

MacOS

Summary by CodeRabbit