Skip to content

regression: opening a contextual bar changes message list scroll position#40757

Draft
gabriellsh wants to merge 1 commit into
release-8.5.0from
fix/messageListContextualBar
Draft

regression: opening a contextual bar changes message list scroll position#40757
gabriellsh wants to merge 1 commit into
release-8.5.0from
fix/messageListContextualBar

Conversation

@gabriellsh
Copy link
Copy Markdown
Member

@gabriellsh gabriellsh commented Jun 1, 2026

Proposed changes (including videos or screenshots)

The way the contextual bar is handled makes the body of the room assume a width of 0. This breaks Virtua somehow, but upon digging their issues, this one stood out inokawa/virtua#225. By changing the body's display to "none" when it's hidden, the issue seises to exist.

Issue(s)

CORE-2225

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Jun 1, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 1, 2026

⚠️ No Changeset found

Latest commit: d57c995

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f78ddbb0-7dee-4070-b756-4e4166974c7a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.92%. Comparing base (995d6ea) to head (d57c995).
⚠️ Report is 2 commits behind head on release-8.5.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-8.5.0   #40757   +/-   ##
==============================================
  Coverage          69.91%   69.92%           
==============================================
  Files               3327     3327           
  Lines             126593   126581   -12     
  Branches           22042    22023   -19     
==============================================
- Hits               88511    88507    -4     
+ Misses             34791    34786    -5     
+ Partials            3291     3288    -3     
Flag Coverage Δ
unit 70.04% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant