regression: opening a contextual bar changes message list scroll position#40757
regression: opening a contextual bar changes message list scroll position#40757gabriellsh wants to merge 1 commit into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.5.0 #40757 +/- ##
==============================================
Coverage 69.91% 69.92%
==============================================
Files 3327 3327
Lines 126593 126581 -12
Branches 22042 22023 -19
==============================================
- Hits 88511 88507 -4
+ Misses 34791 34786 -5
+ Partials 3291 3288 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
The way the contextual bar is handled makes the body of the room assume a width of 0. This breaks Virtua somehow, but upon digging their issues, this one stood out inokawa/virtua#225. By changing the body's display to "none" when it's hidden, the issue seises to exist.
Issue(s)
CORE-2225
Steps to test or reproduce
Further comments