Skip to content

tests: Add CAS and SAML login E2E Test - #7659

Open
Rohit3523 wants to merge 13 commits into
developfrom
e2e-test-for-cas-and-saml
Open

tests: Add CAS and SAML login E2E Test#7659
Rohit3523 wants to merge 13 commits into
developfrom
e2e-test-for-cas-and-saml

Conversation

@Rohit3523

@Rohit3523 Rohit3523 commented Sep 8, 2026

Copy link
Copy Markdown
Member

Proposed changes

Adds Maestro E2E coverage for CAS & SAML login. which had no automated login test. Flow navigates to the candidate Workspace and completes CAS & SAML sign-in through to the rooms list.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1529

How to test or reproduce

  1. configure .maestro/scripts/e2e_account.js from the example with valid CAS credentials
  2. run the CAS Maestro test (e.g. maestro test .maestro/tests/onboarding/login/cas-login.yaml)
  3. complete sign-in when the CAS Login screen appears

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Tests
    • Added automated end-to-end coverage for CAS authentication.
    • Added automated end-to-end coverage for SAML authentication, including web-based login and platform-specific prompts.
    • Added reusable navigation for connecting to the candidate environment and reaching the login screen.
    • Added test configuration and credentials for validating candidate server, CAS, and SAML sign-in flows.
    • Registered the new authentication scenarios in the test suite for ongoing validation.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 302d9e1c-79c0-4a21-b2da-ccb6e661f244

📥 Commits

Reviewing files that changed from the base of the PR and between 686d904 and 66c9c16.

📒 Files selected for processing (1)
  • .sniffler/test-map.json

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: format
🔇 Additional comments (1)
.sniffler/test-map.json (1)

171-182: LGTM!

Also applies to: 191-202


Walkthrough

The PR adds reusable candidate-login navigation and Maestro coverage for CAS and SAML authentication. It adds credentials, platform-specific prompt handling, success checks, and Sniffler registrations.

Changes

Authentication test coverage

Layer / File(s) Summary
Candidate login setup
.maestro/helpers/..., .maestro/scripts/*
Adds the candidate server, SAML and CAS credentials, and a reusable flow that navigates to the candidate login screen.
CAS login flow
.maestro/tests/onboarding/login/cas-login.yaml, .sniffler/test-map.json
Adds CAS authentication steps, platform-specific selectors, password prompt handling, success validation, and test registration.
SAML login flow
.maestro/tests/onboarding/login/saml-login.yaml, .sniffler/test-map.json
Adds browser-based SAML authentication, platform prompt handling, deeplink acceptance, success validation, and test registration.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Maestro
  participant RocketChatApp
  participant AuthProvider
  Maestro->>RocketChatApp: Navigate to candidate login
  Maestro->>RocketChatApp: Select CAS or web login
  RocketChatApp->>AuthProvider: Submit authentication
  AuthProvider-->>RocketChatApp: Complete authentication
  RocketChatApp-->>Maestro: Show rooms-list-view
Loading

Suggested labels: type: chore, area: authentication

Suggested reviewers: diegolmello

Merge Risk: ⚪ Minimal · up to 66c9c

This change adds end-to-end CAS and SAML login coverage without altering application runtime behavior. The flows and their dependency registrations are present, so no merge-blocking production risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding CAS and SAML login end-to-end tests. It is concise and related to the pull request objectives.

Warning

Errors were encountered while retrieving linked issues.

Errors (1)
  • JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Rohit3523
Rohit3523 temporarily deployed to approve_e2e_testing September 8, 2026 19:58 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 changed the title chore: Add CAS login E2E chore: Add CAS and SAML login E2E Test Sep 9, 2026
@Rohit3523
Rohit3523 marked this pull request as ready for review September 10, 2026 13:33

@diegolmello diegolmello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong tag: tests: instead of chore:

@Rohit3523 Rohit3523 changed the title chore: Add CAS and SAML login E2E Test tests: Add CAS and SAML login E2E Test Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants