tests: Add CAS and SAML login E2E Test - #7659
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🔇 Additional comments (1)
WalkthroughThe PR adds reusable candidate-login navigation and Maestro coverage for CAS and SAML authentication. It adds credentials, platform-specific prompt handling, success checks, and Sniffler registrations. ChangesAuthentication test coverage
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Maestro
participant RocketChatApp
participant AuthProvider
Maestro->>RocketChatApp: Navigate to candidate login
Maestro->>RocketChatApp: Select CAS or web login
RocketChatApp->>AuthProvider: Submit authentication
AuthProvider-->>RocketChatApp: Complete authentication
RocketChatApp-->>Maestro: Show rooms-list-view
Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change adds end-to-end CAS and SAML login coverage without altering application runtime behavior. The flows and their dependency registrations are present, so no merge-blocking production risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Errors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
left a comment
There was a problem hiding this comment.
Wrong tag: tests: instead of chore:
Proposed changes
Adds Maestro E2E coverage for CAS & SAML login. which had no automated login test. Flow navigates to the candidate Workspace and completes CAS & SAML sign-in through to the rooms list.
Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1529
How to test or reproduce
.maestro/scripts/e2e_account.jsfrom the example with valid CAS credentialsmaestro test .maestro/tests/onboarding/login/cas-login.yaml)Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit