fix: add error boundaries to prevent full app crashes (#1270)#1344
Open
abu-abdullah22 wants to merge 1 commit into
Open
fix: add error boundaries to prevent full app crashes (#1270)#1344abu-abdullah22 wants to merge 1 commit into
abu-abdullah22 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1270
Summary
Adds React Error Boundaries to prevent single-component errors from crashing
the entire embedded chat widget.
Changes
ErrorBoundarycomponent (packages/react/src/views/ErrorBoundary/)with a fallback UI (retry + reload) using the app's existing
Box,Button,and
Iconcomponents from@embeddedchat/ui-elementsEmbeddedChatcomponent so any unhandled error shows thefallback instead of a blank screen
ChatBodyandChatInputseparately insideChatLayoutso anerror in one doesn't take down the other
ErrorBoundary.test.jsusing@testing-library/reactNote for reviewers
packages/reactcurrently hasjestas a dependency but no working Jestconfig/test script wired up — running
npx jestfails with"Cannot use import statement outside a module" since Babel isn't connected
to Jest's transform pipeline. I added the test file following existing
testing-library patterns used elsewhere in the codebase, but couldn't verify
it runs locally due to this pre-existing gap. Happy to add a jest.config.js