Bug: File upload broken on Rocket.Chat 8.x (uses removed rooms.upload endpoint) #1172

Activity

1. Aryan-Verma-999

   added

   bugSomething isn't workingSomething isn't working

   on Mar 1, 2026
2. rohanesor commented on Oct 19, 2026

   

   rohanesor

   on Oct 19, 2026

   More actions

   This looks like it has already been fixed and can probably be closed.

   rooms.upload is no longer referenced anywhere in the codebase. sendAttachment() in packages/api/src/EmbeddedChatApi.ts now uses exactly the two-step flow this issue asks for:

   const uploadResult = await this._restUpload(`/v1/rooms.media/${this.rid}`, form);
   ...
   return await this._restRequest(
     `/v1/rooms.mediaConfirm/${this.rid}/${uploadResult.file._id}`,
     "POST",
     ...
   );

   Fixed by 46546f3 ("fix: update file upload to use RC 8.x rooms.media API"), merged via #1070 on 2026-03-21. Verified present on current develop (8c542970), and git branch -r --contains 46546f3c confirms it is on develop.

   Flagging rather than closing since I'm not a maintainer — happy to be corrected if some upload path still uses the old endpoint.
3. Aryan-Verma-999

   closed this as completedon Oct 19, 2026
4. Aryan-Verma-999 commented on Oct 19, 2026

   

   Aryan-Verma-999

   on Oct 19, 2026

   CollaboratorAuthor

   More actions

   Thanks for the reminder :)
5. rohanesor commented on Oct 20, 2026

   

   rohanesor

   on Oct 20, 2026

   More actions

   No problem, happy to help keep the tracker tidy.

   While I was looking at the API layer I also picked up #1158 — your earlier #1171 had the right root cause, so #1394 builds on it, with the teardown moved into a finally block so the socket is also closed when the logout request itself fails. Credited you in the PR.

   No rush at all, but if you get a chance: the CI runs on #1387, #1391 and #1394 are all sitting at action_required (first-time contributor), so there's no green check to review against yet. One approval would unblock all three.