Skip to content

Create and pass RNG, so that Global RNG is not reset #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rejuvyesh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create and pass RNG, so that Global RNG is not reset #21

rejuvyesh wants to merge 1 commit into from

Conversation

@rejuvyesh
Copy link

@rejuvyesh rejuvyesh commented Aug 9, 2021

Fixes #20.

@rejuvyesh
Copy link
Author

rejuvyesh commented Aug 9, 2021

There are alternatives possible as well like f should always take one argument method and we create closures that keep track of rng instead. But won't work as easily with f_init and other usages of rand in the function.

@rejuvyesh
Copy link
Author

rejuvyesh commented Aug 20, 2021

@simon-lc pinging in case lost in CompatHelper PRs.

@rejuvyesh
Copy link
Author

rejuvyesh commented Aug 20, 2021

Or if I should make this PR on your personal github?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

newton_solve! resets global Random seed

1 participant

@rejuvyesh