Websockets asyncio#152
Open
gonzalocasas wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying out an alternative, opt-in transport/event loop based on websockets + asyncio.
The new transport can be be manually selected via a
transportkwargs onRos, or set viaset_default_transport, or with an environment variable.I added some benchmarks as well. The benchmarks run on CI, the results are uploaded to the summary page of the CI task, here are the results of one of the latest runs. The conclusion is that the new transport has marginally higher topic throughput.
roslibpy transport benchmark
These numbers are sampled on shared CI infrastructure. Topic p95 and max
latencies can be noisy because of runner scheduling, Docker networking,
and rosbridge timing. Prefer medians and throughput for quick comparisons;
interpret tail latency across several runs.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.rstfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke check).