Repository navigation
generate_gha: omit empty needs for first-stage jobs - #170
Merged
Merged
Conversation
actionlint rejects `needs: []` ("needs section should not be empty"), which
every job of the first stage got. Only emit needs when there is a previous stage.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
traversaro
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jobs of the first stage were emitted with
needs: [], which actionlint rejects ("needs" section should not be empty [syntax-check]).needsis now only written when there is a previous stage (Unix and Windows pipelines); later stages are unchanged.Verified: new test
test_only_later_stages_declare_needs(fails before, passes after); full vinca test suite passes (262 passed); actionlint on a generated two-stage workflow reports the error before and is clean after.🤖 Generated with Claude Code