Repository navigation
Read and write text files as UTF-8 - #166
Merged
traversaro merged 1 commit intoOct 9, 2026
Merged
Conversation
On Windows, open() defaults to the locale encoding (cp1252), so a recipe whose description contains a non-ASCII character (e.g. kortex_description's "™") was written as cp1252 and then failed to load as YAML. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
force-pushed
the
fix/utf8-generated-files
branch
from
October 8, 2026 19:56
519288e to
cc4c9dd
Compare
Contributor
Author
|
@traversaro this is ready for review |
traversaro
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
open()without anencodinguses the locale encoding (cp1252). A package whosepackage.xmldescription has a non-ASCII character (e.g.kortex_description's "™") was then written torecipe.yamlas cp1252, and reading that recipe back as YAML (UTF-8) failed:This passes
encoding="utf-8"to every text-modeopen()in vinca (recipes, variants, generated workflows, snapshots, caches,vinca.yaml, additional recipes, the Windows build script). No behaviour change on Linux/macOS, where UTF-8 is already the default.🤖 Generated with Claude Code