Repository navigation
PR builds: check the patches once per distribution, next to the builds - #95
Merged
Merged
Conversation
The patch check ran in every build job, ~5 minutes on Linux and ~13 on Windows, each time for the patches of all platforms. A job per distribution now generates the recipes of every platform, merges them and checks their patches once, on Linux, while the builds run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
added
the
build:humble
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch check ran as a step of every build job: one
rattler-buildrun per patched recipe, ~5 minutes on Linux and ~11–13 minutes on Windows, and every job checked the patches of all platforms again.Now a separate
<distro> patchesjob runs once per distribution onubuntu-latest, in parallel with the builds:-nand the sameROBOSTACK_UPLOAD_CHANNEL, so it covers the packages being built.check-orphaned-patchesandcheck-patchesonce. Applying a patch doesn't depend on the host, and the checker already covers thelinux/osx/win/emscriptenpatches regardless of the host.The build jobs no longer have the step, and
All greenalso waits for the new job.Checked locally for humble: recipes for linux-64, win-64 and osx-arm64 merged into 337, of which 57 have patches; all 57 apply. A package's recipe is identical for every platform (17 of 17 compared). Labelled
build:humble, so this PR's CI exercises the new job on one distribution.🤖 Generated with Claude Code