Repository navigation
PR builds and generation skip what is already on the upload channel - #51
Merged
Merged
Conversation
While uploads go to a test channel (ROBOSTACK_UPLOAD_CHANNEL), PR builds and the build-branch generation only skipped packages on the distribution's release channel, so every PR rebuilt the packages main had already built and uploaded there (jazzy linux-64: 72 recipes, all on the test channel). The upload channel now counts as published too; without the variable nothing changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the packages on the upload channel skipped, a PR that changes nothing a distribution builds generates no recipes; #50's check made `rs build` fail on that. Only a missing recipes/ (never generated) is an error now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR builds only skipped packages that were already on the distribution's release channel. Main's build branches upload to the test channel (
ROBOSTACK_UPLOAD_CHANNEL), so every PR rebuilt what main had already built: everything new in the monorepo or with a new build number. For example, #49's jazzy linux-64 job built 72 packages; of the 51 package files I could identify in its log, 36 are identical (name, version and build) on the test channel.Change:
ROBOSTACK_UPLOAD_CHANNELis set,rsadds that channel to vinca'sskip_existing. Builds already read from it since Staged builds: also read from the channel uploads are redirected to #21.testpr.yaml(build jobs) andmain.yaml(generation) get the repository variable.Checked:
rs jazzy generate-recipes --platform linux-64gives 72 recipes without the variable and 0 with it. actionlint is clean.🤖 Generated with Claude Code