Repository navigation
rviz_ogre_vendor: don't build Ogre's EXR codec - #116
Open
Tobias-Fischer wants to merge 1 commit into
Open
Tobias-Fischer wants to merge 1 commit into
Tobias-Fischer wants to merge 1 commit into
Conversation
Ogre 1.12's FindOpenEXR only knows OpenEXR 2's library names, so it never finds conda-forge's OpenEXR 3 and skips the codec on the CI runners (none of the published packages has Codec_EXR), but on a machine with a system OpenEXR 2 it mixes conda's headers with /usr's libraries and fails. RViz doesn't use the codec: switch it off, so the build no longer depends on the host. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches off Ogre's EXR codec in
rviz_ogre_vendor(all distributions) with-DOGRE_BUILD_PLUGIN_EXRCODEC=OFF. No functional change: Ogre 1.12'sFindOpenEXRonly knows OpenEXR 2's library names, so it never finds conda-forge's OpenEXR 3 and the codec isn't built on the CI runners (none of the published humble, jazzy, lyrical or rolling packages hasCodec_EXR). On a machine with a system OpenEXR 2 (e.g. Ubuntu'slibopenexr-dev), it mixes conda's headers with/usr's libraries and the build fails. RViz doesn't use the codec, so turning it off makes the build independent of the host.Built locally
libopenexr-dev2.3 installed, where it failed before): builds; the package has the same Ogre plugins as the published one.Codec_EXR, the other codecs as before (Assimp, FreeImage, STBI), andlibOgreOverlaystill links@rpath/libfreetype.6.dylib(humble's FreeType fix from humble: rosdistro sync 2026-10-12 #62).Prepared and built on top of the current rosdistro syncs (#62 humble, #61 jazzy, #60 lyrical, #99 rolling) merged together, so it targets their package versions: merge after them. CI is held with
[skip ci]until the syncs are in. The humble (#62) and rolling (#99) syncs also change those patches; rebase after they merge.🤖 Generated with Claude Code