Repository navigation
Add aruco_ros (not on Windows) - #107
Draft
Tobias-Fischer wants to merge 2 commits into
Draft
Tobias-Fischer wants to merge 2 commits into
Tobias-Fischer wants to merge 2 commits into
Conversation
Ports RoboStack/ros-lyrical#87. The patches make aruco build with OpenCV 5 and Eigen 5 from conda-forge (version requirement, top-level headers, cv::Error::Code exceptions, Eigen3::Eigen), and fix aruco_ros' hard-coded opencv4/ include. jazzy and lyrical (5.0.5) also carry the PR's target_link_libraries / tf2 .hpp changes for aruco_ros; humble and rolling (5.0.6) have those upstream. Co-authored-by: Kamil Baradziej <49471097+baradejoo@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Turns the local checks of this PR into a recipe test, so later rebuilds keep them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports RoboStack/ros-lyrical#87 by @baradejoo: adds
aruco_ros(witharuco,aruco_msgs) to the shared selection, not on Windows (not tried).aruco: builds with OpenCV 5 / Eigen 5 from conda-forge (no OpenCV version requirement, top-levelopencv2/*.hppheaders,cv::Exceptionwithcv::Error::Code,Eigen3::Eigen). The PR's patch for 5.0.5 (jazzy, lyrical), refreshed for 5.0.6 (humble, rolling).aruco_ros: the hard-codedopencv4/opencv2/calib3d.hppinclude; for 5.0.5 also the PR'starget_link_libraries/tf2.hppchanges, which 5.0.6 has upstream.Recipe test:
single(the marker detector) starts and keeps running (shared/tests/ros2-aruco-ros.yaml).Built locally
aruco,aruco_msgs,aruco_rosincl. their recipe tests; thesingle,double,marker_publisherexecutables are installed andsinglestarts.aruco,aruco_msgs,aruco_ros(5.0.6 patches) incl. recipe tests.aruco,aruco_msgs,aruco_rosincl. recipe tests.aruco,aruco_msgs,aruco_rosincl. recipe tests.Prepared and built on top of the current rosdistro syncs (#62 humble, #61 jazzy, #60 lyrical, #99 rolling) merged together, so it targets their package versions: merge after them. CI is held with
[skip ci]until the syncs are in.🤖 Generated with Claude Code