Conversation
elysseaa
requested changes
Mar 14, 2026
| marginBottom: 4, | ||
| }, | ||
| }), | ||
| [props.backgroundColor, props.borderColor, props.padding, currentTheme], |
Contributor
There was a problem hiding this comment.
I think useMemo is used to save computations by caching the dependencies passed into it, but I don't think that things like background color or current theme will change that frequently for it to really need useMemo. But it's technically an optimization, so it doesn't cause problems
| <View style={styles.header}> | ||
| <MaterialDesignIcons | ||
| name="alert-circle-outline" | ||
| color={currentTheme.onSurface} |
Contributor
There was a problem hiding this comment.
This icon is not visible on dark mode but is visible on light mode, I think it has something to do with the onSurface color for dark mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Callout and WarningCallout objects. Confirm look, feel and functionality against https://github.com/RoboJackets/apiary-mobile/blob/main/base/src/main/java/org/robojackets/apiary/base/ui/callout/Callout.kt