Gracefully handle keyboard interrupts#92
Open
ItsDrike wants to merge 5 commits intoRobertCraigie:mainfrom
Open
Gracefully handle keyboard interrupts#92ItsDrike wants to merge 5 commits intoRobertCraigie:mainfrom
ItsDrike wants to merge 5 commits intoRobertCraigie:mainfrom
Conversation
ItsDrike
force-pushed
the
graceful-kbd-interrupts
branch
from
22a0c4d to
e79c5ea
Compare
Author
|
Hey, it's been a while, is there something more I should do here? What's blocking the merge for this? |
|
I would like to see this merged! Just ran into #80! 2024-08-09: After a lot of google searching, I am again back here 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80
Note: I haven't done too much testing here, other than running the provided unit-tests, and general sample run of
python -m pyrightwith testing the ctrl+c behavior. Also, I've only tested this on a linux machine since I don't have any windows machine available. So I'd ask for a lot more in-depth testing before approving and merging.