Removed curl_close to avoid deprecation warning on PHP 8.5#155
Merged
willpower232 merged 1 commit intoRobThree:masterfrom Jan 5, 2026
Merged
Removed curl_close to avoid deprecation warning on PHP 8.5#155willpower232 merged 1 commit intoRobThree:masterfrom
willpower232 merged 1 commit intoRobThree:masterfrom
Conversation
…ion warning on PHP 8.5
Collaborator
NicolasCARPi
approved these changes
Jan 3, 2026
Collaborator
NicolasCARPi
left a comment
NicolasCARPi
left a comment
There was a problem hiding this comment.
Before merging this change, the commit message must be improved to include a reference to the deprecation (https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.curl) and explain why it is no longer necessary: Since 8.0 a CurlHandle object is returned, and curl_close() has no effect, so this change won't impact earlier versions.
Collaborator
|
@NicolasCARPi something like this in the squash merge? 
|
Collaborator
|
@willpower232 LGTM ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed curl_close that has no effect since PHP 8.0 to avoid deprecation warning on PHP 8.5