Skip to content

Instance display name and root color highlighting#47

Closed
Hobbes4Pres wants to merge 9 commits into
RobThePCGuy:masterfrom
Hobbes4Pres:instance-display-name
Closed

Instance display name and root color highlighting#47
Hobbes4Pres wants to merge 9 commits into
RobThePCGuy:masterfrom
Hobbes4Pres:instance-display-name

Conversation

@Hobbes4Pres

Copy link
Copy Markdown
Contributor

Updated to support the configuration file display name for each instance using an additional column. Added a color indicator when the status of Root is turned on within an instance.

I have well over 20 instances in Bluestacks so instance numbers are hard themselves to identify which instance is being adjusted.

New UI

Added another column within the Instances widget to show the BlueStacks instance display_name from the config file to go with the unique name. This makes it much easier to confirm which instance is referenced.
Added a new dictionary to return instance display names alongside global and instance statuses.
Changed display_names type from bool to str.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for parsing and displaying instance display names in the UI, alongside visual improvements such as highlighting active root statuses in green. The feedback suggests returning the new display_names key in the exception handler of get_complete_root_statuses to ensure API consistency, and renaming a variable in main.py to adhere to PEP 8 style guidelines while simplifying its stylesheet.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread config_handler.py Outdated
Comment thread main.py Outdated
@RobThePCGuy

Copy link
Copy Markdown
Owner

Thanks for this, the display-name column and root-color highlighting are genuinely useful (tested both locally with synthetic instance data and they work correctly, including on refresh).

I just merged #45, which replaces the old single-file main.py with a nav-rail layout (views/dashboard_page.py, views/instances_page.py, views/main_window.py, etc.). That rewrote the instance-list UI you were changing, so this PR now conflicts and can't merge as-is.

config_handler.py and constants.py are untouched by #45, so that half of your change is still good. The part that needs to move is the grid changes in main.py — that logic now lives in views/instances_page.py. Could you rebase onto current master and reapply the display-name column + root highlighting there? Happy to point you at the relevant spot in the new file if that's easier than digging through it.

@RobThePCGuy

Copy link
Copy Markdown
Owner

Update: rather than asking you to redo the rebase, I ported this onto the new views/ layout myself in #51 (your display-name parsing, the color highlighting, and the scroll area for large instance lists, all carried over and credited to you). Closing this in favor of #51 once that merges. Thanks for the contribution, this was a genuinely useful addition for anyone running a lot of instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants