Method overloads for Texture::Load#375
Merged
RobLoach merged 1 commit intoRobLoach:masterfrom Feb 28, 2026
Merged
Conversation
…e loading new texture
Owner
|
As for Shaders, I guess it could impact them. But I'm not sure how often you would re-load a shader. |
Contributor
Author
|
True, shaders are not that great of an example for this since they don't have an instance method for loading. However, I think the Wave class might exhibit similar behavior potentially along with some other classes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method overloads have been made for the Texture class to unload the previous texture before loading in a new texture. I'm not sure if other classes (ex: Shader) would have this issue, but it might be worth updating other classes to follow this same behavior for consistency reasons.