Skip to content

docs(ui): design the Compass UI visual-regression gate (RIG-2154) #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rigel-mintaka wants to merge 6 commits into
base: main
Choose a base branch
from
+590 −0
Open

docs(ui): design the Compass UI visual-regression gate (RIG-2154) #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1be9dd
docs(ui): design the Compass UI visual-regression gate (RIG-2154)
rigel-mintaka Sep 5, 2026
0fa9b6b
docs(ui): correct the visual-gate threshold mechanism and stale citat…
rigel-mintaka Sep 6, 2026
652259f
docs(ui): clear the visual-gate record's non-blocking review findings…
rigel-mintaka Sep 6, 2026
42ff662
docs(ui): correct the per-shot ratio literals and job anchors (RIG-2154)
rigel-mintaka Sep 6, 2026
40f6768
docs(ui): make the per-shot ratio executable and its scope conditiona…
rigel-mintaka Sep 6, 2026
da58168
docs(ui): scope the last two flat override-count claims (RIG-2154)
rigel-mintaka Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/designs/DECISIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,3 +449,4 @@ check enforces the mechanical half. Full rationale:
| DL-318 | Pre-stream/inner error and abort content surface on the session trace as a dedicated `SessionError` message (`compass.v1.SessionEvent` oneof field 10) with a `SessionErrorKind` discriminator (ERROR \| ABORTED), a failure `message`, and an optional HTTP `status` — not `SessionNotice`, not a comms `Message` block (RIG-2616) | Active (Matt, 2026-09-02) | [error/abort surfacing](agent/compass-agent-error-abort-surfacing/design.md) |
| DL-322 | Error/abort emit rule: `reason=error` emits `SessionError(ERROR)` AND the existing `ERRORED` lifecycle transition (additive — board/presence/delivery key off `ERRORED`); `reason=aborted` emits `SessionError(ABORTED)` with NO lifecycle transition (abort is not a crash) and replaces the prior counted-`UnmappedEvent` staging | Active (Matt, 2026-09-02) | [error/abort surfacing](agent/compass-agent-error-abort-surfacing/design.md) |
| DL-323 | The `SessionError` trace frame rides the FrameSink never-drop PRIORITY lane (not the bounded drop-oldest trace queue), via an `isSessionError` classifier extending the `frame-sink.ts` priority predicate — matching the `SessionInjection` never-drop carve-out, so surfaced failure content is as durable-on-the-spine as the lifecycle transition it reports | Active (Matt, 2026-09-02) | [error/abort surfacing](agent/compass-agent-error-abort-surfacing/design.md) |
| DL-341 | Compass UI visual regression is gated by built-in Playwright `toHaveScreenshot` (not a hosted visual-diff service), with baseline PNGs committed in-repo and regenerated ONLY by a pinned nix Chromium in CI via a `regen-visual-baselines` `workflow_dispatch` lane, never from a developer machine; wired as a `visual-gate` moon task on @playwright/test 1.62.1. Tolerance values, hard-gate-vs-advisory rollout, and capture coverage are NOT ruled here \| they are the record's open questions (OQ-1/OQ-4/OQ-5) awaiting Matt (RIG-2154) | Active (Matt, 2026-09-06) | [visual regression gate](ui/compass-visual-regression-gate/design.md) |
Loading
Loading