revert(deps): pin go back to 1.26.6, undo #650 (RIG-3303) - #901
Closed
rigel-mintaka wants to merge 1 commit into
Closed
revert(deps): pin go back to 1.26.6, undo #650 (RIG-3303)#901rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
Renovate #650 bumped the go compiler 1.26.6->1.27.1, but nilaway (the gating nil-flow analyzer in the pinned nixpkgs devenv shell) is a go1.26-built binary that cannot parse the go1.27 stdlib. It fails with `file requires newer Go version go1.27 (application built with go1.26)` and `unknown field rfd in struct literal of type splicePipe`, reddening `compass-go:nilaway` -> `moon (go)` -> `rollup` (the required check) and gating the entire merge queue since 2026-09-05T17:27Z. Pure revert: restores `tools/toolchain/versions/go.nix` to 1.26.6 and `devenv.lock` go-overlay rev to the pre-bump value, byte-identical to the pre-#650 tree. go.mod floor is `go 1.25.0`, unaffected. The durable regroup (pin a go1.27-built nilaway + group go+nilaway in Renovate, then re-land) is tracked as a dependencies-lane follow-up. Spec-impact: none. Refs RIG-3303. Refs #650. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Compass engineering docs preview: https://compass-repo-rig-3303-revert.compass-eng-docs.pages.dev Deployed from |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate #650 bumped the go compiler 1.26.6->1.27.1, but nilaway (the gating nil-flow analyzer in the pinned nixpkgs devenv shell) is a go1.26-built binary that cannot parse the go1.27 stdlib. It fails with
file requires newer Go version go1.27 (application built with go1.26)andunknown field rfd in struct literal of type splicePipe, reddeningcompass-go:nilaway->moon (go)->rollup(the required check) and gating the entire merge queue since 2026-09-05T17:27Z.Pure revert: restores
tools/toolchain/versions/go.nixto 1.26.6 anddevenv.lockgo-overlay rev to the pre-bump value, byte-identical to the pre-#650 tree. go.mod floor isgo 1.25.0, unaffected. The durable regroup (pin a go1.27-built nilaway + group go+nilaway in Renovate, then re-land) is tracked as a dependencies-lane follow-up.Spec-impact: none. Refs RIG-3303. Refs #650.
Co-authored-by: Matt Wilkinson matt@rigel.build