War3MapW3i support version 33 and War3MapW3e support version 12#101
Open
tdauth wants to merge 7 commits into
Open
War3MapW3i support version 33 and War3MapW3e support version 12#101tdauth wants to merge 7 commits into
tdauth wants to merge 7 commits into
Conversation
tdauth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed War3MapW3i for file version 33 using the spec here https://github.com/ChiefOfGxBxL/WC3MapSpecification/blob/master/Info/0-33.md and War3MapW3e for file version 12 using the spec here https://github.com/ChiefOfGxBxL/WC3MapSpecification/blob/master/Terrain/12.md (not sure about the flags).
I have added a unit tests with files from my map WoW Reforged.
I have removed getByteLength since it is not used anywhere and needs to be maintained for no reason.
Only with these changes a Reforged map will load at all.