Update fields and generalize repo URL encoding#30
Merged
likeajumprope merged 5 commits intoReproNim:mainfrom Apr 16, 2026
Merged
Update fields and generalize repo URL encoding#30likeajumprope merged 5 commits intoReproNim:mainfrom
likeajumprope merged 5 commits intoReproNim:mainfrom
Conversation
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ReproInventory data model and frontend, renaming the "review" field to "description", converting "open_dataset" and "assessment" to boolean types, and cleaning up unused fields. The UI for adding and editing materials now uses checkboxes for dataset availability, and a new utility derives the GitHub repository URL dynamically. Feedback was provided to ensure that unchecking the "open dataset" checkbox explicitly sets the value to "false" rather than "null", preventing issues with YAML generation and browser filtering.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the handling of the "Open Dataset" and "Description" fields across the Add, Edit, and Browse Material dialogs, and makes the GitHub repository URL dynamic based on the deployment context. It also removes several unused or deprecated fields to streamline the codebase and user interface.
Field and UI Refactoring:
AddMaterialDialogandEditMaterialDialog, replacing the previous enum/select input. Filtering in the browser is updated to use this boolean logic. [1] [2] [3] [4] [5] [6]Removal of Deprecated/Unused Fields:
functionality,assessment,exclude_from_repro_inventory, andalias_links. The assessment filter was also removed from the browser. [1] [2] [3] [4] [5] [6] [7]Dynamic GitHub Repo URL:
getGitHubRepoUrlinfrontend/src/lib/github.tsto dynamically determine the GitHub repository URL based on the runtime hostname, supporting forks and local development. All hardcoded repo URLs are replaced with this function. [1] [2] [3] [4] [5] [6]Data Fetching Improvement:
reproinventory_data.jsonis now constructed usingimport.meta.env.BASE_URLfor improved compatibility with different deployment environments.Type Clean-up:
OpenDatasetEnumtype and its usage throughout the codebase, reflecting the new boolean representation. [1] [2] [3] [4] [5]These changes collectively simplify the code, improve clarity for users, and enhance compatibility with forks and different deployment setups.