Add missing forward declaration to rtcore_scene.h#555
Merged
Conversation
Add missing forward declaration for RTCGeometry in rtcore_scene.h
dbs4261
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds an RTCGeometry forward declaration to rtcore_scene.h so the scene API can reference RTCGeometry (e.g., rtcAttachGeometry, rtcGetGeometry) without requiring consumers to include rtcore_geometry.h first.
Changes:
- Add
typedef struct RTCGeometryTy* RTCGeometry;toinclude/embree4/rtcore_scene.h.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stefanatwork
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing forward declaration for RTCGeometry in rtcore_scene.h